Add SaladCloud API Key detector #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
abmussani
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Thank you @seniorquico for the addition in detectors. I have posted few comments.
seniorquico
force-pushed
the
saladcloud-api
branch
from
418ae07
to
8a54eb7
Compare
|
Rebased to resolve merge conflicts. |
abasit-folio3
approved these changes
Sep 11, 2024
abmussani
approved these changes
Sep 11, 2024
kashifkhan0771
approved these changes
Sep 18, 2024
|
@seniorquico LGTM, would you mind resolving the conflicts? We'll get it merged in after they get resolved. |
seniorquico
force-pushed
the
saladcloud-api
branch
from
8a54eb7
to
d2938fb
Compare
|
@zricethezav Rebased. Thanks! |
ahrav
approved these changes
Oct 11, 2024
|
Thanks, @ahrav! Do you know if someone will be available to look at trufflesecurity/how-to-rotate#29 soon, as well? The changes in this PR included a link to that guide, but it's not yet live. |
|
@seniorquico stand by, this change actually doesnt build since it doesnt satisfy the detector interface (missing description) |
|
I'm sorry, @zricethezav! I just opened #3399. |
abmussani
added a commit
to abmussani/trufflehog
that referenced
this pull request
Oct 14, 2024
* main: (127 commits) Update SaladCloud description (trufflesecurity#3399) fix tests (trufflesecurity#3400) [chore] Update custom detector default description (trufflesecurity#3398) add description to salad (trufflesecurity#3397) Add detector for SaladCloud API Keys (trufflesecurity#3273) fix(deps): update module github.com/xanzy/go-gitlab to v0.111.0 (trufflesecurity#3393) Add SliceContainsString common util (trufflesecurity#3395) fix: pr template link to golangci-lint (trufflesecurity#3392) fix(deps): update golang.org/x/exp digest to f66d83c (trufflesecurity#3389) Separate detector tests into unit/integration (trufflesecurity#3274) Manually upgrade github dep (trufflesecurity#3387) Updated Fastly Personal Token Detector (trufflesecurity#3386) fix(deps): update module google.golang.org/api to v0.200.0 (trufflesecurity#3391) [Fix] Snowflake privatelink Support (trufflesecurity#3286) Enhanced the easyinsight detector (trufflesecurity#3384) Log skipped files on debug level (trufflesecurity#3383) build: update retracted bluemonday ver (trufflesecurity#3369) Fix git binary handling and add a smoke test (trufflesecurity#3379) fix(deps): update module google.golang.org/protobuf to v1.35.1 (trufflesecurity#3382) Added Cisco Meraki API Key detector (trufflesecurity#3367) ... # Conflicts: # pkg/engine/defaults.go # pkg/pb/detectorspb/detectors.pb.go # proto/detectors.proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds an API key detector for SaladCloud (https://salad.com/). SaladCloud is a community/distributed cloud provider.
I also opened a "How To Rotate" guide PR: trufflesecurity/how-to-rotate#29
Checklist:
make test-community)?make lintthis requires golangci-lint)?