Merge pull request #20 from truefoundry/hl/lowercase_bucket_name

sachincool · web-flow · commit f13be5a02ff2 · 2024-11-30T14:38:59.000+05:30
fix(locals.tf): ensure bucket names are lowercase for consistency and compliance with naming conventions
diff --git a/locals.tf b/locals.tf
@@ -8,7 +8,7 @@ locals {
     var.tags
   )
   truefoundry_unique_name = "${var.cluster_name}-platform"
-  bucket_name             = var.blob_storage_enable_override ? var.blob_storage_override_name : "${var.cluster_name}-ml"
+  bucket_name             = var.blob_storage_enable_override ? lower(var.blob_storage_override_name) : lower("${var.cluster_name}-ml")
   policy_arns = [
     var.feature_blob_storage_enabled ? aws_iam_policy.truefoundry_platform_feature_s3_policy[0].arn : null,
     var.feature_parameter_store_enabled ? aws_iam_policy.truefoundry_platform_feature_parameter_store_policy[0].arn : null,

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ locals {`
`8`	`8`	`var.tags`
`9`	`9`	`)`
`10`	`10`	`truefoundry_unique_name = "${var.cluster_name}-platform"`
`11`		`- bucket_name = var.blob_storage_enable_override ? var.blob_storage_override_name : "${var.cluster_name}-ml"`
	`11`	`+ bucket_name = var.blob_storage_enable_override ? lower(var.blob_storage_override_name) : lower("${var.cluster_name}-ml")`
`12`	`12`	`policy_arns = [`
`13`	`13`	`var.feature_blob_storage_enabled ? aws_iam_policy.truefoundry_platform_feature_s3_policy[0].arn : null,`
`14`	`14`	`var.feature_parameter_store_enabled ? aws_iam_policy.truefoundry_platform_feature_parameter_store_policy[0].arn : null,`