-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand environment configurability #93
Comments
Thank you for bringing this up, @dcramer! This makes sense. It's not well-documented, but you can also currently configure the app with 2 environment variables instead of files:
Would using those environment variables work for you, or would you still prefer a different approach? |
@itsojon we do use the first one, as well as DATABASE_URL, but TROTTO_CONFIG is a complex solution to configuration given you have to serialize a yaml file. My suggestion will be just to infer more defaults from standard env variables. Otherwise people have to setup a build process to convert the app.yml into the serialized version, which is fine, but more process = more problems. |
@dcramer that's fair. I'd welcome a PR to support more simple env var config. We can document these in the docs as "basic" config options and
|
Would love to be able to configure more basics via an environment variable, including:
This makes it fairly easy to deploy to Google Cloud Run / Kubernetes without ever managing a custom configuration file or custom docker image.
I will throw up a PR if yall are in favor. Will take a look at other relevant non-layout settings that might make sense as well.
The text was updated successfully, but these errors were encountered: