Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin python-version #81

Open
dcramer opened this issue Feb 24, 2021 · 3 comments
Open

Pin python-version #81

dcramer opened this issue Feb 24, 2021 · 3 comments

Comments

@dcramer
Copy link
Contributor

dcramer commented Feb 24, 2021

Dockerfile is using 3.7, readme says 3.8. Is there a suggested version and should it also be pinned via pyenv (.python-version)?

@itsojon
Copy link
Collaborator

itsojon commented Feb 24, 2021

Good question, that's confusing. All tests are run with 3.7, so I'll update the README to say 3.7.

I'd love to pin the version for the virtual env. Since there doesn't seem to be an equivalent of .python-version for venv, we can prescribe pyenv. Sound good to you?

@dcramer
Copy link
Contributor Author

dcramer commented Feb 24, 2021

Yep - I can propose some other suggestions that we often use @getsentry to make devenvs easier to manage

@itsojon
Copy link
Collaborator

itsojon commented Feb 24, 2021

@dcramer I'd greatly appreciate that! There are still some warts in here from the closed-to-open-source switch, but it's quite stable as the core our customers are using constantly every day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants