Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net):fix block fetching issue in FetchBlockService #5094

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

jwrct
Copy link
Contributor

@jwrct jwrct commented Mar 24, 2023

What does this PR do?
Fix the issue of repeated block fetching in FetchBlockService.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@jwrct jwrct changed the title fix(net):fix the problem of repeated fetch block in FetchBlockService fix(net):fix block fetching issue in FetchBlockService Mar 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #5094 (74c8179) into release_v4.7.2 (6db2db9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.2    #5094      +/-   ##
====================================================
- Coverage             54.72%   54.72%   -0.01%     
- Complexity             8238     8240       +2     
====================================================
  Files                   841      841              
  Lines                 49715    49719       +4     
  Branches               5460     5461       +1     
====================================================
+ Hits                  27205    27207       +2     
- Misses                20370    20373       +3     
+ Partials               2140     2139       -1     
Impacted Files Coverage Δ
...in/java/org/tron/core/net/peer/PeerConnection.java 33.33% <0.00%> (-1.00%) ⬇️
...java/org/tron/core/net/service/adv/AdvService.java 40.77% <0.00%> (ø)
...core/net/service/fetchblock/FetchBlockService.java 20.23% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jwrct jwrct merged commit e7858ea into tronprotocol:release_v4.7.2 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants