Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): add encoder to avoid any external usage #5001

Merged

Conversation

halibobo1205
Copy link
Contributor

@halibobo1205 halibobo1205 commented Feb 16, 2023

What does this PR do?
rollback deleted rule encoder class for logback
Why are these changes required?
avoid the use of custom profiles for logback, previous PR : #4985
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #5001 (6c51cff) into release_v4.7.1 (e693d8a) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.1    #5001      +/-   ##
====================================================
- Coverage             54.73%   54.68%   -0.06%     
  Complexity             8217     8217              
====================================================
  Files                   840      841       +1     
  Lines                 49655    49702      +47     
  Branches               5451     5456       +5     
====================================================
  Hits                  27178    27178              
- Misses                20334    20379      +45     
- Partials               2143     2145       +2     
Impacted Files Coverage Δ
...org/tron/common/log/layout/MultiLayoutPattern.java 0.00% <0.00%> (ø)
...g/tron/core/capsule/utils/FastByteComparisons.java 60.00% <0.00%> (-8.00%) ⬇️
...ork/src/main/java/org/tron/core/trie/TrieImpl.java 57.88% <0.00%> (-0.36%) ⬇️
...mework/src/main/java/org/tron/core/db/Manager.java 52.78% <0.00%> (-0.31%) ⬇️
...ain/java/org/tron/core/services/RpcApiService.java 4.82% <0.00%> (-0.13%) ⬇️
...n/java/org/tron/core/db2/core/SnapshotManager.java 72.93% <0.00%> (+0.28%) ⬆️
.../src/main/java/org/tron/core/ChainBaseManager.java 90.97% <0.00%> (+1.38%) ⬆️
.../common/storage/leveldb/LevelDbDataSourceImpl.java 72.48% <0.00%> (+1.74%) ⬆️
...rc/main/java/org/tron/core/db/BlockIndexStore.java 53.84% <0.00%> (+7.69%) ⬆️
...org/tron/core/exception/ItemNotFoundException.java 66.66% <0.00%> (+33.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@halibobo1205 halibobo1205 merged commit a46a607 into tronprotocol:release_v4.7.1 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants