Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Parser 3.3.0 #1762

Closed
bkuhlmann opened this issue Jan 15, 2024 · 3 comments
Closed

Update to Parser 3.3.0 #1762

bkuhlmann opened this issue Jan 15, 2024 · 3 comments

Comments

@bkuhlmann
Copy link

bkuhlmann commented Jan 15, 2024

Why

Hello. 👋 Would it be possible to upgrade to Parser 3.3.0 since it's not possible to upgrade to RuboCop 1.60.0 since it requires Parser 3.3.0 or higher? Here's the error I get when updating to RuboCop 1.60.0 and attempting to use Reek 6.2.0 at the same time:

Could not find compatible versions

Because reek >= 6.1.4 depends on parser ~> 3.2.0
  and rubocop >= 1.60.0 depends on parser >= 3.3.0.2,
  reek >= 6.1.4 is incompatible with rubocop >= 1.60.0.
And because every version of caliber depends on rubocop ~> 1.60,
  reek >= 6.1.4 is incompatible with caliber >= 0.
So, because Gemfile depends on caliber >= 0
  and Gemfile depends on reek ~> 6.2,
  version solving has failed.

How

This should only require updating the reek.gemspec to spec.add_runtime_dependency 'parser', '~> 3.3.0'. This is related to this code review.

Notes

  • OS: macOS 13.6.3
  • Ruby: ruby 3.3.0 (2023-12-25 revision 5124f9ac75) +YJIT [arm64-darwin22.6.0]
  • Reek: 6.2.0
@BrianHawley
Copy link

#1761 fixed this, but it still needs to be released.

@bkuhlmann
Copy link
Author

bkuhlmann commented Jan 18, 2024

Thanks!

Also, with RuboCop 1.60.1 out, the build failures should be able to be resolved now.

@mvz
Copy link
Collaborator

mvz commented Feb 1, 2024

Release 6.3.0 is out now and uses Parser 3.3.x: #1767

@mvz mvz closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants