Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple problems with UncommunicativeVariableName detector #1066

Open
troessner opened this issue Sep 9, 2016 · 0 comments
Open

Multiple problems with UncommunicativeVariableName detector #1066

troessner opened this issue Sep 9, 2016 · 0 comments
Labels
defect

Comments

@troessner
Copy link
Owner

Follow-up to #1065
The UncommunicativeVariableName smell detector:

  • does not take the context into account, hence context based configuration via comments or config file is not working
  • does not use the same configuration loading mechanism like all the other Uncommunicative* detectors

I stumbled across this years ago and thought "oh well, it looks like shit but hopefully isn't a problem".
And now looks what came back to bite me in the ass :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvz @troessner