-
Notifications
You must be signed in to change notification settings - Fork 17
Implement Implicit Incompressible SPH (IISPH) #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 67.84% 66.18% -1.67%
==========================================
Files 110 113 +3
Lines 7558 7824 +266
==========================================
+ Hits 5128 5178 +50
- Misses 2430 2646 +216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the docs and system.jl yet. I will do that in the next review to keep the reviews small. Please first incorporate these changes.
Also, please resolve open conversations after implementing the changes.
|
Please resolve conversations after implementing the changes. And please fix the tests. |
the viscosity model
smoothing kernel and length
efaulhaber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/run-gpu-tests |
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
|
/run-gpu-tests |
No description provided.