Skip to content

Conversation

@noahstruschka
Copy link
Contributor

No description provided.

@efaulhaber efaulhaber marked this pull request as draft April 7, 2025 09:39
@noahstruschka noahstruschka requested a review from efaulhaber May 27, 2025 12:46
@efaulhaber efaulhaber marked this pull request as ready for review May 28, 2025 10:04
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

❌ Patch coverage is 18.79699% with 216 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.18%. Comparing base (a5972b0) to head (a2e2d9d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...chemes/fluid/implicit_incompressible_sph/system.jl 14.34% 197 Missing ⚠️
src/io/io.jl 0.00% 10 Missing ⚠️
test/systems/iisph_system.jl 0.00% 5 Missing ⚠️
src/general/semidiscretization.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   67.84%   66.18%   -1.67%     
==========================================
  Files         110      113       +3     
  Lines        7558     7824     +266     
==========================================
+ Hits         5128     5178      +50     
- Misses       2430     2646     +216     
Flag Coverage Δ
unit 66.18% <18.79%> (-1.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the docs and system.jl yet. I will do that in the next review to keep the reviews small. Please first incorporate these changes.

Also, please resolve open conversations after implementing the changes.

@noahstruschka noahstruschka requested a review from efaulhaber May 30, 2025 12:49
@efaulhaber
Copy link
Member

Please resolve conversations after implementing the changes. And please fix the tests.

efaulhaber
efaulhaber previously approved these changes Sep 23, 2025
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efaulhaber efaulhaber changed the title IISPH (Masterarbeit Noah) Implement Implicit Incompressible SPH (IISPH) Sep 23, 2025
@efaulhaber
Copy link
Member

/run-gpu-tests

Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
@efaulhaber
Copy link
Member

/run-gpu-tests

@svchb svchb enabled auto-merge (squash) September 24, 2025 08:50
@svchb svchb merged commit c70f70a into trixi-framework:main Sep 24, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants