We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thesis_gemein_2022
TrixiAtmo.jl
In the branch https://github.com/trixi-framework/TrixiAtmo.jl/tree/ab_lucas, I am trying to add the results from https://github.com/NichtLucas/Trixi.jl/tree/thesis_gemein_2022 using Trixi as a dependency.
Here is the $v_2$ velocity plot from the elixir https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/examples/elixir_moist_euler_nonhydrostatic_gravity_waves.jl
I have not made any changes to the internals of the code from https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/examples/elixir_moist_euler_nonhydrostatic_gravity_waves.jl, just added import and using as needed. We could do some more tests for validation. If things are okay, we can decide how to merge this into main (how to break into PRs and review).
import
using
main
The text was updated successfully, but these errors were encountered:
Nice work! Can you please create a draft PR such that we can see how much code would have to be merged, in order to make an informed decision?
Sorry, something went wrong.
Completed in #2.
No branches or pull requests
In the branch https://github.com/trixi-framework/TrixiAtmo.jl/tree/ab_lucas, I am trying to add the results from https://github.com/NichtLucas/Trixi.jl/tree/thesis_gemein_2022 using Trixi as a dependency.
Here is the$v_2$ velocity plot from the elixir https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/examples/elixir_moist_euler_nonhydrostatic_gravity_waves.jl
I have not made any changes to the internals of the code from https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/examples/elixir_moist_euler_nonhydrostatic_gravity_waves.jl, just added
import
andusing
as needed. We could do some more tests for validation. If things are okay, we can decide how to merge this intomain
(how to break into PRs and review).The text was updated successfully, but these errors were encountered: