Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort by length option #224

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

KLewin23
Copy link

Adds the option to be able to sort within import groups by length mentioned #76, choices are

  • asc shortest to longest
  • desc longest to shortest
  • null no length rule applied

After length imports are sorted alphabetically

I have an internal fork with this implemented already so this doesn't affect me, but this is the general setup I have been using

@devlsh
Copy link

devlsh commented Apr 24, 2023

Would love to have this!

@expiritus2
Copy link

I also would love to have this. When it will be on the prod guys?

@KLewin23
Copy link
Author

Had to update the branch, think it needs reaproving

@spookyuser
Copy link

If this gets merged prettier can be renamed prettiest :)

@jackdh
Copy link

jackdh commented Sep 29, 2023

+1 for this, could we merge it?

@KLewin23
Copy link
Author

Gonna need someone to approve and merge it, keep coming back to it approved with merge blocks

types/index.d.ts Outdated Show resolved Hide resolved
KLewin23 and others added 2 commits November 15, 2023 14:26
Co-authored-by: annes <76728727+annesnour03@users.noreply.github.com>
@KLewin23
Copy link
Author

@annesnour03 can you approve so I can get this put away

@KLewin23
Copy link
Author

I still cant merge it @annesnour03 so idk if you can if not... it waits even more XD

@spookyuser
Copy link

image

@jackdh
Copy link

jackdh commented Nov 16, 2023

@ayusharma @byara come to our rescue please!

@Miguel-A-Jara
Copy link

Any news on this :)? @ayusharma & @byara

@Dugnist
Copy link

Dugnist commented Aug 17, 2024

@ayusharma @byara please add this

@KLewin23
Copy link
Author

1 year later XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants