Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@trivago/prettier-plugin-sort-imports@4.0.0" has unmet peer dependency "@vue/compiler-sfc@3.x" #195

Closed
1 task done
VladimirMikulic opened this issue Dec 16, 2022 · 2 comments

Comments

@VladimirMikulic
Copy link

VladimirMikulic commented Dec 16, 2022

Your Environment

  • Prettier version: 2.8.1
  • node version: 18.12.1
  • package manager: yarn@1.22.19
  • IDE: VScode

Describe the bug

Screenshot_20221216_174658

To Reproduce

  1. npm init -y to create an empty project
  2. Run yarn install @trivago/prettier-plugin-sort-imports
  3. See yarn report the warning

Expected behavior

I'd expect warning not be shown. If @vue/compiler-sfc@3.x is required for this package to work, then it should be a dependency. Otherwise, it should be removed altogether.

Contribute to @trivago/prettier-plugin-sort-imports

  • I'm willing to fix this bug if I get input on @vue/compiler-sfc in this package 🥇

Thanks!

@leomotors
Copy link
Contributor

I think this is fixed in #189 just that they did not create release for it yet.

@VladimirMikulic
Copy link
Author

Good point @leomotors. Thanks.
@byara when can we expect release? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants