-
Notifications
You must be signed in to change notification settings - Fork 1.6k
build: update build.py to pass versions as input parameter and convert version map to dictionary #7500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is it possible to start a new pipeline for this PR to check if it is goes well? + should we test newly added flags? |
I've tested the changes via this pipeline 18898001 |
Co-authored-by: Olga Andreeva <124622579+oandreeva-nv@users.noreply.github.com>
I'm fine with these changes, just clarify help messages, as I mentioned here If @mc-nv and @nv-kmcgill53 have no objections and there are no disturbances with our current CI, i.e. not the vllm specific, we should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be using the FLAGS
for all of the versioning instead of the DEFAULT_TRITON_VERSION_MAP
since each of the values in the map can be overwritten as passed arguments to build.py
. You are defaulting the FLAG
values to use the map as well. I don't really want bidirectional assignment from the FLAGS
and the map, too confusing.
Co-authored-by: Kyle McGill <101670481+nv-kmcgill53@users.noreply.github.com>
Since there were some recent changes, I went ahead and ran a new pipeline to ensure that things were still working as expected |
What does the PR do?
example - https://github.com/triton-inference-server/vllm_backend/blob/mesharma-ci/ci/build/build_source.sh#L60
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
[Not ready for review, not needed to merge this change] triton-inference-server/vllm_backend#49
Where should the reviewer start?
all changes are contained within build.py script
Test plan:
Build: Trigger CI for new vllm_backend Triton releases vllm_backend#49
All actions are successful and pipeline checks have also passed.
CI Pipeline ID:
17157949
Caveats:
N/A
Background
I was unable to set any specific vllm version while triggering a build and test CI pipeline from vllm_backend repository due to the hard-coding in this build.py script.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A