-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]:Custom Backend Tracing #7403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandreeva-nv
added
enhancement
New feature or request
module: backends
Issues related to the backends
module: server
Issues related to the server core and frontends
PR: feat
A new feature
labels
Jul 2, 2024
20 tasks
oandreeva-nv
requested review from
indrajit96,
Tabrizian,
tanmayv25,
GuanLuo,
krishung5 and
nnshah1
July 2, 2024 22:18
GuanLuo
reviewed
Jul 3, 2024
oandreeva-nv
force-pushed
the
oandreeva-custom-trace-activity
branch
from
July 3, 2024 23:36
741b015
to
69434d7
Compare
krishung5
reviewed
Jul 3, 2024
Co-authored-by: Kris Hung <krish@nvidia.com>
oandreeva-nv
force-pushed
the
oandreeva-custom-trace-activity
branch
from
July 5, 2024 21:56
89cf169
to
636cc13
Compare
GuanLuo
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
module: backends
Issues related to the backends
module: server
Issues related to the server core and frontends
PR: feat
A new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
NOTE: currently targeting refactor PR: #7390 , after refactor is merged, will target main, or we can merge this PR to refactor and then refactor to main.
Currently Triton Trace capabilities are limited to reporting of a predefined set of activities listed here. Neither of the listed options support tracing a custom activity that a potential user might want to capture.
This PR includes frontend adjustments to support Custom Backend features, including:
TRITONSERVER_TRACE_CUSTOM_ACTIVITY
_START
or_END
, an event is added to a currently active span (i.e. on top of the stack)Sample OpenTelemetry trace:
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
server PR: #7403
identity backend: triton-inference-server/identity_backend#30
Where should the reviewer start?
TEP
Test plan: Added tests for Triton Trace API and OpenTelemetry Trace API.
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)