-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Oracle Cloud in deploy #6850
Conversation
Forked repo from main and adapted AWS deploy to deploy on Oracle Cloud
Update readme and modelRepositoryPath to the correct URL
Hi @bruno-garbaccio, thanks for submitting this PR. Have you submitted a CLA as described here: https://github.com/triton-inference-server/server/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla? |
Hi @rmccorm4 , thanks for your answer. I just submitted it, I didn't see this requirement, thanks for the heads-up. |
Thanks! CC @nealvaidya @mengdong @nv-kmcgill53 @whoisj could you give this a look over when you get a chance? |
Hi @rmccorm4, @nealvaidya , @mengdong , @nv-kmcgill53 @whoisj I know you guys are busy with a ton of things but do you think this could be reviewed this week? I would like to have a communication in one of our Oracle Blogs about the support of OCI for the deployment and we have a deadline for this if we want it to happen during GTC. I run the tests in my OCI tenant,took the "aws" repo as a basis and try to respect the README.md format that was set for "aws". Do not hesitate to reach out for questions! |
the helm chart and instruction looks good to me! |
Hi, I saw the pre-commit run failed at line 160 in the readme, at the level of the url: s3://https://<OCI_NAMESPACE>.compat.objectstorage.<OCI_REGION>.oraclecloud.com:443/triton-inference-server-repository This url comes from the documentation https://docs.nvidia.com/deeplearning/triton-inference-server/user-guide/docs/user_guide/model_repository.html and in the OCI case there are some placeholders to fill. I don't have a full error log. @rmccorm4 , can you tell me if there's anything I could do? |
Hi @bruno-garbaccio, I believe pre-commit is just failing for trailing whitespace - I added some suggestions above to fix it. Otherwise, LGTM and I can approve/merge. |
Co-authored-by: Ryan McCormick <mccormick.codes@gmail.com>
Co-authored-by: Ryan McCormick <mccormick.codes@gmail.com>
Dong, J, and Neal all gave their seal of approval, so merging. |
Following issue #6849,, here is a proposal to have Triton server working on the OKE service of Oracle Cloud.
The directory deploy/oci is based on deploy/aws with some minor adjustments to have it run on Oracle Cloud.