-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify L0_backend_python bls test for BLS decoupled support #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
previously approved these changes
Mar 6, 2023
krishung5
force-pushed
the
krish-decoupled-bls
branch
from
March 6, 2023 17:35
dc58a65
to
07ade61
Compare
krishung5
changed the title
Lower the tensor size to avoid intermittent issue
Lower the tensor size to avoid intermittent issue and disable multiprocessing for decoupled case for L0_backend_python bls test
Mar 6, 2023
krishung5
force-pushed
the
krish-decoupled-bls
branch
from
March 7, 2023 03:59
6cfc746
to
de156bb
Compare
krishung5
changed the title
Lower the tensor size to avoid intermittent issue and disable multiprocessing for decoupled case for L0_backend_python bls test
Modify L0_backend_python bls test for BLS decoupled support
Mar 7, 2023
@Tabrizian I went ahead and added some unittest cases for the response iterator. Please let me know if there is other corner cases that I missed. Thanks! |
Tabrizian
reviewed
Mar 7, 2023
krishung5
force-pushed
the
krish-decoupled-bls
branch
from
March 7, 2023 18:45
de156bb
to
1900f09
Compare
Tabrizian
previously approved these changes
Mar 7, 2023
krishung5
force-pushed
the
krish-decoupled-bls
branch
from
March 7, 2023 22:48
1900f09
to
39f55a7
Compare
Tabrizian
reviewed
Mar 8, 2023
Tabrizian
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tensor byte size is still at least 1GB in order to trigger the out of memory error.