fix: MessageQueueShm head index boundary check #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinggeh
changed the title
yinggeh
changed the title
|
No unit test because triton-inference-server/server#8273 makes the exploitation impossible. |
yinggeh
commented
Jul 1, 2025
| @@ -54,105 +51,6 @@ using cudaStream_t = void*; | |||
|
|
|||
| namespace triton { namespace backend { namespace python { | |||
|
|
|||
| #define LOG_IF_EXCEPTION(X) \ | |||
There was a problem hiding this comment.
Moved log related code to new files to break circular dependency.
yinggeh
commented
Jul 1, 2025
| @@ -1569,138 +1570,6 @@ Stub::ProcessBLSResponseDecoupled(std::unique_ptr<IPCMessage>& ipc_message) | |||
| } | |||
| } | |||
|
|
|||
| std::unique_ptr<Logger> Logger::log_instance_; | |||
There was a problem hiding this comment.
Moved log related code to new files to break circular dependency.
yinggeh
commented
Jul 1, 2025
| @@ -0,0 +1,170 @@ | |||
| // Copyright 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
Moved log related code to new files to break circular dependency.
yinggeh
commented
Jul 1, 2025
| @@ -0,0 +1,134 @@ | |||
| // Copyright 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
Moved log related code to new files to break circular dependency.
This reverts commit 87f6f2a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
When attacker registers the same shm created by python backend, they can overwrite
MessageQueueShm::headdata with a very large index and inject malicious code to the memory space.Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
Where should the reviewer start?
The index boundary check is in src/message_queue.h
Test plan:
30975011
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)