Implement Error for LoadingError #153
Conversation
src/lib.rs
Outdated
| WalkDir(ref error) => error.fmt(f), | ||
| Io(ref error) => error.fmt(f), | ||
| #[cfg(feature = "yaml-load")] | ||
| ParseSyntax(_) => write!(f, "Invalid syntax file"), |
There was a problem hiding this comment.
These cases could be implemented as _ => write!(f, self.description()) instead of duplicating the messages.
There was a problem hiding this comment.
For some reason, I didn't think it would work in this direction (because Error depends on fmt::Display).. but that's much better, of course. Updated.
Yes, a library that removes some of the boilerplate involved in error handling would certainly be a good idea. By the way: thank you for this amazing library! |
src/lib.rs
Outdated
| ParseTheme(_) => write!(f, "Invalid syntax theme"), | ||
| ReadSettings(_) => write!(f, "Invalid syntax theme settings"), | ||
| BadPath => write!(f, "Invalid path"), | ||
| ParseSyntax(_) => write!(f, "{}", self.description()), |
There was a problem hiding this comment.
Still not a fan of this duplication. I'd prefer either a _ pattern or if you really want the exhaustiveness checking (I don't think it's important in this case since description is a fine default) you can use a separate item for ParseSyntax and then ParseTheme(_) | ReadSettings(_) | BadPath => for the rest.
There was a problem hiding this comment.
Sorry.. just now saw your _ => prefix in the first comment. I've updated it to a catch-all pattern.
| match *self { | ||
| WalkDir(ref error) => error.fmt(f), | ||
| Io(ref error) => error.fmt(f), | ||
| _ => write!(f, "{}", self.description()), |
There was a problem hiding this comment.
I think this should not rely on Error::description() since it is going to be deprecated soon?
There was a problem hiding this comment.
I didn't know that.
Anyhow, it's still required for now and we can easily refactor it to remove it once the default implementation has been stable for a while, or we switch to failure.
Implements
std::error::ErrorforLoadingError.This is a first step towards #94. Things could definitely be improved by also implementing
Errorfor the other syntect-specific errors.