add docs for jdbc extra credentials, fixing #1910 #11791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryleooo
requested review from
ebyhr,
jhlodin and
mosabua
and removed request for
ebyhr and
mosabua
mosabua
requested changes
Apr 5, 2022
Member
There was a problem hiding this comment.
We should not add the CLI and JDBC related docs into the connector docs .. instead we should document the extra credential usage in the CLI page and the JDBC driver page and then link there.
There is an ongoing PR that needs to be merged asap so that you can proceed with this as a next step.
jerryleooo
force-pushed
the
extra_credentials_docs
branch
from
b05178e to
c0191a2
Compare
Member
Author
|
@mosabua thanks for the review, I have made changes accordingly |
mosabua
requested changes
Apr 11, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
A couple of general things to update please
- leave secret usage to be the first solution mentioned
- wrap extra credential fragment text at 80 char
- explain what you mean by "key" in those context, and where the credentials are looked up from, maybe this whole thing is worth a separate page we link to in the authentication docs, from the current explanation I do not know how to use this
- provide separate section in CLI docs about extra credential usage
- provide separate section in JDBC docs
- link to those sections in the connectors
Member
|
👋 @jerryleooo - this PR is inactive and doesn't seem to be under development, and it might already be implemented. If you'd like to continue work on this at any point in the future, feel free to re-open. |
Member
|
This is addressed by #14454. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an improvement on docs.
No, only adding docs
N/A
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(*) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(*) Release notes entries required with the following suggested text: