Migrate unit tests to JUnit 5

[martint]

• Update parser and core query unit tests to JUnit #9362
• Add checker for JUnit @Test annotation in overridden tests #14027
• provide a checker ensuring that a JUnit test does not extend from TestNG-annotated test class, to avoid situation when @Test or setup methods are inherited but not firing up
• provide a checker ensuring that a TestNG test does not extend from JUnit-annotated test class, to avoid situation when @Test or setup methods are inherited but not firing up
• provide a checker ensuring a TestNG test doesn't use JUnit setup/cleanup annotations (eg cleanup might not get fired)
• Add missing JUnit lifecycle annotation #19467
• Migrate tests to JUnit #19454
• Add validation for missing Test annotations #19358
• Migrate connector smoke tests to JUnit #19324
• Migrate tests to JUnit #19238
• Remove TestNG from SPI #19214
• Migrate various tests to JUnit #19195
• Migrate aggregation tests to JUnit #18765
• Migrate Accumulo tests to JUnit #18763
• Migrate mysql-event-listener tests to JUnit #18686
• Migrate jmx connector tests to JUnit #18685
• Migrate exchange-filesystem to JUnit #18681
• Migrate exchange-hdfs to JUnit #18680
• Migrate blackhole tests to JUnit #18679
• Migrate accumulo-iterators to JUnit #18678
• Migrate atop tests to JUnit #18677
• Migrate Elasticsearch tests to JUnit #18676
• Fix structure and execution of type tests #18594
• Migrate tests to JUnit #18199
• Migrate type tests to JUnit #18198
• Migrate TestPageProcessor to JUnit #18192
• Migrate aggregation function tests to JUnit #18191
• Migrate analyzer tests to JUnit #18190
• Migrate query tests to JUnit #18185
• Migrate plan tests to JUnit #18164
• Migrate some tests to JUnit #18115
• Migrate rule tests to JUnit #18018
• Migrate JDBC driver tests to JUnit #19550
• Migrate tests to JUnit #19535
• Run JUnit tests in parallel #19554
• Migrate hive-file-formats to JUnit #19556
• Migrate trino-cache to JUnit #19558
• Migrate some trino-delta tests to JUnit #19559
• Migrate tests to JUnit #19665
• migrate remaining tests to JUnit
• remove testng from test classpath

[Damans227]

@martint I would like to be part of this project and can help you in planning and executing the roadmap for it. I am willing to dedicate a fixed amount of hours on daily basis for next few months if that helps. Lemme know.

[martint]

@Damans227, that would be great! The changes can be done mostly incrementally by tackling individual test classes. Take a look at the PR I linked above for an example.

[Damans227]

@martint Ok, scanning through the files changed in this PR: #9362, it appears to me that we are updating the tests from using org.testng framework to Junit5. So, which modules in the codebase do we aim to cover as part of this issue/ project ? Since, you've already updated trino-main & trino-parser in core, should I continue with other modules in the same folder ?

[martint]

I only updated trino-parser and a small portion of trino-main. The goal would be to replace it everywhere.

[Damans227]

Got it! Thanks for replying.

[Damans227]

I have updated the tests in the sql>analyzer module. How do I validate my changes before sending a PR ? Is there a maven command to do so ? Apologies in advance as these are very rookie questions.

[martint]

• provide a checker ensuring that a JUnit test does not extend from TestNG-annotated test class, to avoid situation when @Test or setup methods are inherited but not firing up
• provide a checker ensuring that a TestNG test does not extend from JUnit-annotated test class, to avoid situation when @test or setup methods are inherited but not firing up
• provide a checker ensuring a TestNG test doesn't use JUnit setup/cleanup annotations (eg cleanup might not get fired)

These are handled indirectly by the ReportUnannotatedMethods check

[findepi]

These are handled indirectly by the ReportUnannotatedMethods check

In one direction ("checker ensuring that a TestNG test does not extend from JUnit-annotated test class"), yes.