Skip to content

Commit b73e9f6

Browse files
daindain
committed
Remove BlockBuilder writeLong
1 parent 84a66c5 commit b73e9f6

36 files changed

+150
-97
lines changed

‎core/trino-main/src/main/java/io/trino/operator/HashAggregationOperator.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
import static com.google.common.base.Preconditions.checkState;
4747
import static io.airlift.units.DataSize.Unit.MEGABYTE;
4848
import static io.trino.operator.aggregation.builder.InMemoryHashAggregationBuilder.toTypes;
49+
import static io.trino.spi.type.BigintType.BIGINT;
4950
import static io.trino.sql.planner.optimizations.HashGenerationOptimizer.INITIAL_HASH_VALUE;
5051
import static io.trino.type.TypeUtils.NULL_HASH_CODE;
5152
import static java.util.Objects.requireNonNull;
@@ -572,7 +573,7 @@ private Page getGlobalAggregationOutput()
572573

573574
while (channel < groupByTypes.size()) {
574575
if (channel == groupIdChannel.orElseThrow()) {
575-
output.getBlockBuilder(channel).writeLong(groupId);
576+
BIGINT.writeLong(output.getBlockBuilder(channel), groupId);
576577
}
577578
else {
578579
output.getBlockBuilder(channel).appendNull();
@@ -582,7 +583,7 @@ private Page getGlobalAggregationOutput()
582583

583584
if (hashChannel.isPresent()) {
584585
long hashValue = calculateDefaultOutputHash(groupByTypes, groupIdChannel.orElseThrow(), groupId);
585-
output.getBlockBuilder(channel).writeLong(hashValue);
586+
BIGINT.writeLong(output.getBlockBuilder(channel), hashValue);
586587
channel++;
587588
}
588589

‎core/trino-main/src/test/java/io/trino/block/BenchmarkRowBlockBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void benchmarkBeginBlockEntry(BenchmarkData data, Blackhole blackhole)
5454
for (int i = 0; i < data.rows; i++) {
5555
data.getBlockBuilder().buildEntry(fieldBuilders -> {
5656
for (int fieldIndex = 0; fieldIndex < data.getTypes().size(); fieldIndex++) {
57-
fieldBuilders.get(fieldIndex).writeLong(data.getRandom().nextLong());
57+
BIGINT.writeLong(fieldBuilders.get(fieldIndex), data.getRandom().nextLong());
5858
}
5959
});
6060
}

‎core/trino-main/src/test/java/io/trino/block/TestBlockBuilder.java

Lines changed: 41 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import com.google.common.collect.ImmutableList;
1717
import io.airlift.slice.Slices;
1818
import io.trino.spi.PageBuilder;
19+
import io.trino.spi.block.ArrayBlockBuilder;
1920
import io.trino.spi.block.Block;
2021
import io.trino.spi.block.BlockBuilder;
2122
import io.trino.spi.type.ArrayType;
@@ -55,20 +56,21 @@ public void testMultipleValuesWithNull()
5556
@Test
5657
public void testNewBlockBuilderLike()
5758
{
58-
ArrayType longArrayType = new ArrayType(BIGINT);
59-
ArrayType arrayType = new ArrayType(longArrayType);
60-
List<Type> channels = ImmutableList.of(BIGINT, VARCHAR, arrayType);
59+
List<Type> channels = ImmutableList.of(BIGINT, VARCHAR, new ArrayType(new ArrayType(BIGINT)));
6160
PageBuilder pageBuilder = new PageBuilder(channels);
6261
BlockBuilder bigintBlockBuilder = pageBuilder.getBlockBuilder(0);
6362
BlockBuilder varcharBlockBuilder = pageBuilder.getBlockBuilder(1);
64-
BlockBuilder arrayBlockBuilder = pageBuilder.getBlockBuilder(2);
63+
ArrayBlockBuilder arrayBlockBuilder = (ArrayBlockBuilder) pageBuilder.getBlockBuilder(2);
6564

6665
for (int i = 0; i < 100; i++) {
67-
BIGINT.writeLong(bigintBlockBuilder, i);
68-
VARCHAR.writeSlice(varcharBlockBuilder, Slices.utf8Slice("test" + i));
69-
BlockBuilder blockBuilder = longArrayType.createBlockBuilder(null, 1);
70-
longArrayType.writeObject(blockBuilder, BIGINT.createBlockBuilder(null, 2).writeLong(i).writeLong(i * 2).build());
71-
arrayType.writeObject(arrayBlockBuilder, blockBuilder);
66+
int value = i;
67+
BIGINT.writeLong(bigintBlockBuilder, value);
68+
VARCHAR.writeSlice(varcharBlockBuilder, Slices.utf8Slice("test" + value));
69+
arrayBlockBuilder.buildEntry(elementBuilder -> {
70+
ArrayBlockBuilder nestedArrayBuilder = (ArrayBlockBuilder) elementBuilder;
71+
nestedArrayBuilder.buildEntry(valueBuilder -> BIGINT.writeLong(valueBuilder, value));
72+
nestedArrayBuilder.buildEntry(valueBuilder -> BIGINT.writeLong(valueBuilder, value * 2));
73+
});
7274
pageBuilder.declarePosition();
7375
}
7476

@@ -85,15 +87,20 @@ public void testNewBlockBuilderLike()
8587
@Test
8688
public void testGetPositions()
8789
{
88-
BlockBuilder blockBuilder = BIGINT.createFixedSizeBlockBuilder(5).appendNull().writeLong(42L).appendNull().writeLong(43L).appendNull();
90+
BlockBuilder blockBuilder = BIGINT.createFixedSizeBlockBuilder(5);
91+
blockBuilder.appendNull();
92+
BIGINT.writeLong(blockBuilder, 42L);
93+
blockBuilder.appendNull();
94+
BIGINT.writeLong(blockBuilder, 43L);
95+
blockBuilder.appendNull();
8996
int[] positions = new int[] {0, 1, 1, 1, 4};
9097

9198
// test getPositions for block builder
92-
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 0, positions.length), BIGINT.createFixedSizeBlockBuilder(5).appendNull().writeLong(42).writeLong(42).writeLong(42).appendNull().build());
93-
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 1, 4), BIGINT.createFixedSizeBlockBuilder(5).writeLong(42).writeLong(42).writeLong(42).appendNull().build());
94-
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 2, 1), BIGINT.createFixedSizeBlockBuilder(5).writeLong(42).build());
95-
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 0, 0), BIGINT.createFixedSizeBlockBuilder(5).build());
96-
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 1, 0), BIGINT.createFixedSizeBlockBuilder(5).build());
99+
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 0, positions.length), buildBigintBlock(null, 42, 42, 42, null));
100+
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 1, 4), buildBigintBlock(42, 42, 42, null));
101+
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 2, 1), buildBigintBlock(42));
102+
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 0, 0), buildBigintBlock());
103+
assertBlockEquals(BIGINT, blockBuilder.getPositions(positions, 1, 0), buildBigintBlock());
97104

98105
// out of range
99106
assertInvalidPosition(blockBuilder, new int[] {-1}, 0, 1);
@@ -104,11 +111,11 @@ public void testGetPositions()
104111

105112
// test getPositions for block
106113
Block block = blockBuilder.build();
107-
assertBlockEquals(BIGINT, block.getPositions(positions, 0, positions.length), BIGINT.createFixedSizeBlockBuilder(5).appendNull().writeLong(42).writeLong(42).writeLong(42).appendNull().build());
108-
assertBlockEquals(BIGINT, block.getPositions(positions, 1, 4), BIGINT.createFixedSizeBlockBuilder(5).writeLong(42).writeLong(42).writeLong(42).appendNull().build());
109-
assertBlockEquals(BIGINT, block.getPositions(positions, 2, 1), BIGINT.createFixedSizeBlockBuilder(5).writeLong(42).build());
110-
assertBlockEquals(BIGINT, block.getPositions(positions, 0, 0), BIGINT.createFixedSizeBlockBuilder(5).build());
111-
assertBlockEquals(BIGINT, block.getPositions(positions, 1, 0), BIGINT.createFixedSizeBlockBuilder(5).build());
114+
assertBlockEquals(BIGINT, block.getPositions(positions, 0, positions.length), buildBigintBlock(null, 42, 42, 42, null));
115+
assertBlockEquals(BIGINT, block.getPositions(positions, 1, 4), buildBigintBlock(42, 42, 42, null));
116+
assertBlockEquals(BIGINT, block.getPositions(positions, 2, 1), buildBigintBlock(42));
117+
assertBlockEquals(BIGINT, block.getPositions(positions, 0, 0), buildBigintBlock());
118+
assertBlockEquals(BIGINT, block.getPositions(positions, 1, 0), buildBigintBlock());
112119

113120
// out of range
114121
assertInvalidPosition(block, new int[] {-1}, 0, 1);
@@ -127,6 +134,20 @@ public void testGetPositions()
127134
assertTrue(isIdentical.get());
128135
}
129136

137+
private static Block buildBigintBlock(Integer... values)
138+
{
139+
BlockBuilder blockBuilder = BIGINT.createFixedSizeBlockBuilder(5);
140+
for (Integer value : values) {
141+
if (value == null) {
142+
blockBuilder.appendNull();
143+
}
144+
else {
145+
BIGINT.writeLong(blockBuilder, value);
146+
}
147+
}
148+
return blockBuilder.build();
149+
}
150+
130151
private static void assertInvalidPosition(Block block, int[] positions, int offset, int length)
131152
{
132153
assertThatThrownBy(() -> block.getPositions(positions, offset, length).getLong(0, 0))

‎core/trino-main/src/test/java/io/trino/block/TestLongArrayBlock.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import io.trino.spi.block.BlockBuilder;
1818
import io.trino.spi.block.LongArrayBlock;
1919
import io.trino.spi.block.LongArrayBlockBuilder;
20-
import io.trino.spi.block.VariableWidthBlockBuilder;
2120
import org.testng.annotations.Test;
2221

2322
import java.util.Optional;
@@ -49,17 +48,17 @@ public void testCopyPositions()
4948
public void testLazyBlockBuilderInitialization()
5049
{
5150
Slice[] expectedValues = createTestValue(100);
52-
BlockBuilder emptyBlockBuilder = new VariableWidthBlockBuilder(null, 0, 0);
51+
BlockBuilder emptyBlockBuilder = new LongArrayBlockBuilder(null, 0);
5352

54-
BlockBuilder blockBuilder = new VariableWidthBlockBuilder(null, expectedValues.length, 32 * expectedValues.length);
53+
LongArrayBlockBuilder blockBuilder = new LongArrayBlockBuilder(null, expectedValues.length);
5554
assertEquals(blockBuilder.getSizeInBytes(), emptyBlockBuilder.getSizeInBytes());
5655
assertEquals(blockBuilder.getRetainedSizeInBytes(), emptyBlockBuilder.getRetainedSizeInBytes());
5756

5857
writeValues(expectedValues, blockBuilder);
5958
assertTrue(blockBuilder.getSizeInBytes() > emptyBlockBuilder.getSizeInBytes());
6059
assertTrue(blockBuilder.getRetainedSizeInBytes() > emptyBlockBuilder.getRetainedSizeInBytes());
6160

62-
blockBuilder = blockBuilder.newBlockBuilderLike(null);
61+
blockBuilder = (LongArrayBlockBuilder) blockBuilder.newBlockBuilderLike(null);
6362
assertEquals(blockBuilder.getSizeInBytes(), emptyBlockBuilder.getSizeInBytes());
6463
assertEquals(blockBuilder.getRetainedSizeInBytes(), emptyBlockBuilder.getRetainedSizeInBytes());
6564
}
@@ -96,7 +95,7 @@ private static BlockBuilder createBlockBuilderWithValues(Slice[] expectedValues)
9695
return blockBuilder;
9796
}
9897

99-
private static void writeValues(Slice[] expectedValues, BlockBuilder blockBuilder)
98+
private static void writeValues(Slice[] expectedValues, LongArrayBlockBuilder blockBuilder)
10099
{
101100
for (Slice expectedValue : expectedValues) {
102101
if (expectedValue == null) {

‎core/trino-main/src/test/java/io/trino/connector/TestingTableFunctions.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,7 @@ public TableFunctionProcessorState process(List<Optional<Page>> input)
682682
BlockBuilder builder = BIGINT.createBlockBuilder(null, page.getPositionCount());
683683
for (long index = processedPositions; index < processedPositions + page.getPositionCount(); index++) {
684684
// TODO check for long overflow
685-
builder.writeLong(index);
685+
BIGINT.writeLong(builder, index);
686686
}
687687
processedPositions = processedPositions + page.getPositionCount();
688688
return usedInputAndProduced(new Page(builder.build()));
@@ -789,7 +789,7 @@ public TableFunctionProcessorState process(List<Optional<Page>> input)
789789
BlockBuilder builder = BIGINT.createBlockBuilder(null, page.getPositionCount());
790790
for (long index = processedPositions; index < processedPositions + page.getPositionCount(); index++) {
791791
// TODO check for long overflow
792-
builder.writeLong(index);
792+
BIGINT.writeLong(builder, index);
793793
}
794794
processedPositions = processedPositions + page.getPositionCount();
795795
indexes = builder.build();
@@ -1079,7 +1079,7 @@ public TableFunctionProcessorState process(List<Optional<Page>> input)
10791079
// pass-through index for input_1
10801080
BlockBuilder input1PassThroughBuilder = BIGINT.createBlockBuilder(null, 1);
10811081
if (input1Present) {
1082-
input1PassThroughBuilder.writeLong(input1EndIndex - 1);
1082+
BIGINT.writeLong(input1PassThroughBuilder, input1EndIndex - 1);
10831083
}
10841084
else {
10851085
input1PassThroughBuilder.appendNull();
@@ -1088,7 +1088,7 @@ public TableFunctionProcessorState process(List<Optional<Page>> input)
10881088
// pass-through index for input_2
10891089
BlockBuilder input2PassThroughBuilder = BIGINT.createBlockBuilder(null, 1);
10901090
if (input2Present) {
1091-
input2PassThroughBuilder.writeLong(input2EndIndex - 1);
1091+
BIGINT.writeLong(input2PassThroughBuilder, input2EndIndex - 1);
10921092
}
10931093
else {
10941094
input2PassThroughBuilder.appendNull();

‎core/trino-main/src/test/java/io/trino/operator/BenchmarkGroupByHashOnSimulatedData.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import io.trino.spi.block.Block;
2121
import io.trino.spi.block.BlockBuilder;
2222
import io.trino.spi.block.DictionaryBlock;
23+
import io.trino.spi.block.LongArrayBlockBuilder;
2324
import io.trino.spi.type.BigintType;
2425
import io.trino.spi.type.CharType;
2526
import io.trino.spi.type.DoubleType;
@@ -163,7 +164,7 @@ public enum ColumnType
163164
BIGINT(BigintType.BIGINT, (blockBuilder, positionCount, seed) -> {
164165
Random r = new Random(seed);
165166
for (int i = 0; i < positionCount; i++) {
166-
blockBuilder.writeLong((r.nextLong() >>> 1)); // Only positives
167+
BigintType.BIGINT.writeLong(blockBuilder, r.nextLong() >>> 1); // Only positives
167168
}
168169
}),
169170
INT(IntegerType.INTEGER, (blockBuilder, positionCount, seed) -> {
@@ -175,7 +176,7 @@ public enum ColumnType
175176
DOUBLE(DoubleType.DOUBLE, (blockBuilder, positionCount, seed) -> {
176177
Random r = new Random(seed);
177178
for (int i = 0; i < positionCount; i++) {
178-
blockBuilder.writeLong((r.nextLong() >>> 1)); // Only positives
179+
((LongArrayBlockBuilder) blockBuilder).writeLong(r.nextLong() >>> 1); // Only positives
179180
}
180181
}),
181182
VARCHAR_25(VarcharType.VARCHAR, (blockBuilder, positionCount, seed) -> {

‎core/trino-main/src/test/java/io/trino/operator/BenchmarkWindowOperator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ private RowPagesBuilder buildPages(int currentPartitionIdentifier, List<Type> ty
193193
currentGroupIdentifier = groupIdentifier++;
194194
}
195195

196-
firstColumnBlockBuilder.writeLong(currentGroupIdentifier);
197-
secondColumnBlockBuilder.writeLong(currentPartitionIdentifier);
196+
BIGINT.writeLong(firstColumnBlockBuilder, currentGroupIdentifier);
197+
BIGINT.writeLong(secondColumnBlockBuilder, currentPartitionIdentifier);
198198
++currentNumberOfRowsInPartition;
199199
}
200200

‎core/trino-main/src/test/java/io/trino/operator/TestTableFinishOperator.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import io.trino.operator.TableFinishOperator.TableFinishOperatorFactory;
2525
import io.trino.operator.TableFinishOperator.TableFinisher;
2626
import io.trino.operator.aggregation.TestingAggregationFunction;
27-
import io.trino.spi.block.Block;
2827
import io.trino.spi.block.LongArrayBlockBuilder;
2928
import io.trino.spi.connector.ConnectorOutputMetadata;
3029
import io.trino.spi.statistics.ColumnStatisticMetadata;
@@ -144,10 +143,10 @@ public void testStatisticsAggregation()
144143
assertEquals(tableFinisher.getFragments(), ImmutableList.of(Slices.wrappedBuffer(new byte[] {1}), Slices.wrappedBuffer(new byte[] {2})));
145144
assertEquals(tableFinisher.getComputedStatistics().size(), 1);
146145
assertEquals(getOnlyElement(tableFinisher.getComputedStatistics()).getColumnStatistics().size(), 1);
147-
Block expectedStatisticsBlock = new LongArrayBlockBuilder(null, 1)
148-
.writeLong(7)
149-
.build();
150-
assertBlockEquals(BIGINT, getOnlyElement(tableFinisher.getComputedStatistics()).getColumnStatistics().get(statisticMetadata), expectedStatisticsBlock);
146+
147+
LongArrayBlockBuilder expectedStatistics = new LongArrayBlockBuilder(null, 1);
148+
BIGINT.writeLong(expectedStatistics, 7);
149+
assertBlockEquals(BIGINT, getOnlyElement(tableFinisher.getComputedStatistics()).getColumnStatistics().get(statisticMetadata), expectedStatistics.build());
151150

152151
assertEquals(driverContext.getMemoryUsage(), 0, "memoryUsage");
153152
}

‎core/trino-main/src/test/java/io/trino/operator/project/TestDictionaryAwarePageProjection.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ public boolean process()
435435
int offset = selectedPositions.getOffset();
436436
int[] positions = selectedPositions.getPositions();
437437
for (int index = nextIndexOrPosition + offset; index < offset + selectedPositions.size(); index++) {
438-
blockBuilder.writeLong(verifyPositive(block.getLong(positions[index], 0)));
438+
BIGINT.writeLong(blockBuilder, verifyPositive(block.getLong(positions[index], 0)));
439439
if (yieldSignal.isSet()) {
440440
nextIndexOrPosition = index + 1 - offset;
441441
return false;
@@ -445,7 +445,7 @@ public boolean process()
445445
else {
446446
int offset = selectedPositions.getOffset();
447447
for (int position = nextIndexOrPosition + offset; position < offset + selectedPositions.size(); position++) {
448-
blockBuilder.writeLong(verifyPositive(block.getLong(position, 0)));
448+
BIGINT.writeLong(blockBuilder, verifyPositive(block.getLong(position, 0)));
449449
if (yieldSignal.isSet()) {
450450
nextIndexOrPosition = position + 1 - offset;
451451
return false;

‎core/trino-main/src/test/java/io/trino/spiller/TestBinaryFileSpiller.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
package io.trino.spiller;
1515

1616
import com.google.common.collect.ImmutableList;
17+
import io.airlift.slice.Slices;
1718
import io.trino.FeaturesConfig;
1819
import io.trino.RowPagesBuilder;
1920
import io.trino.execution.buffer.PageSerializer;
@@ -45,7 +46,6 @@
4546
import static io.trino.spi.type.DoubleType.DOUBLE;
4647
import static io.trino.spi.type.VarbinaryType.VARBINARY;
4748
import static io.trino.spi.type.VarcharType.VARCHAR;
48-
import static java.lang.Double.doubleToLongBits;
4949
import static org.testng.Assert.assertEquals;
5050

5151
@Test(singleThreaded = true)
@@ -110,9 +110,9 @@ public void testFileVarbinarySpiller()
110110
BlockBuilder col2 = DOUBLE.createBlockBuilder(null, 1);
111111
BlockBuilder col3 = VARBINARY.createBlockBuilder(null, 1);
112112

113-
col1.writeLong(42);
114-
col2.writeLong(doubleToLongBits(43.0));
115-
col3.writeLong(doubleToLongBits(43.0)).writeLong(1);
113+
BIGINT.writeLong(col1, 42);
114+
DOUBLE.writeDouble(col2, 43.0);
115+
VARBINARY.writeSlice(col3, Slices.allocate(16).getOutput().appendDouble(43.0).appendLong(1).slice());
116116

117117
Page page = new Page(col1.build(), col2.build(), col3.build());
118118

‎core/trino-main/src/test/java/io/trino/spiller/TestFileSingleStreamSpiller.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import com.google.common.collect.Iterators;
1818
import com.google.common.util.concurrent.ListeningExecutorService;
1919
import io.airlift.slice.Slice;
20+
import io.airlift.slice.Slices;
2021
import io.trino.execution.buffer.PagesSerdeUtil;
2122
import io.trino.memory.context.LocalMemoryContext;
2223
import io.trino.operator.PageAssertions;
@@ -45,7 +46,6 @@
4546
import static io.trino.spi.type.BigintType.BIGINT;
4647
import static io.trino.spi.type.DoubleType.DOUBLE;
4748
import static io.trino.spi.type.VarbinaryType.VARBINARY;
48-
import static java.lang.Double.doubleToLongBits;
4949
import static java.nio.file.Files.newInputStream;
5050
import static java.util.concurrent.Executors.newCachedThreadPool;
5151
import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
@@ -168,9 +168,9 @@ private Page buildPage()
168168
BlockBuilder col2 = DOUBLE.createBlockBuilder(null, 1);
169169
BlockBuilder col3 = VARBINARY.createBlockBuilder(null, 1);
170170

171-
col1.writeLong(42);
172-
col2.writeLong(doubleToLongBits(43.0));
173-
col3.writeLong(doubleToLongBits(43.0)).writeLong(1);
171+
BIGINT.writeLong(col1, 42);
172+
DOUBLE.writeDouble(col2, 43.0);
173+
VARBINARY.writeSlice(col3, Slices.allocate(16).getOutput().appendDouble(43.0).appendLong(1).slice());
174174

175175
return new Page(col1.build(), col2.build(), col3.build());
176176
}

‎core/trino-main/src/test/java/io/trino/spiller/TestFileSingleStreamSpillerFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public void testDistributesSpillOverPathsBadDisk()
140140
private Page buildPage()
141141
{
142142
BlockBuilder col1 = BIGINT.createBlockBuilder(null, 1);
143-
col1.writeLong(42);
143+
BIGINT.writeLong(col1, 42);
144144
return new Page(col1.build());
145145
}
146146

0 commit comments

Comments
 (0)