Enable experimental_python_types by default and change the name

[damian3031]

Describe the feature

Enable experimental_python_types by default.
Change this parameter name to legacy_python_types.

Describe alternatives you've considered

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[hashhar]

legacy_python_types might not be descriptive enough. What about raw_results/untyped_results?

[hashhar]

Also as a part of this we should make sure we document clearly the limitations of the new default and mention how to workaround them when needed.

[damian3031]

@hashhar If I understand correctly, logic behind utilising current passed parameter experimental_python_types is here

So if this parameter is True, then type mapping is performed.

So, after changing this parameter name to raw_results/untyped_results, setting raw_results to True would cause to perform mapping, shouldn't it be the opposite?

Maybe we could name this parameter differently, instead of raw_results/untyped_results maybe sth like typed_results/mapped_results? and then by default mapped_results == True and mapping is performed?

Or maybe I could add negation here, rename to raw_result and leave default value to False, so by default raw_result == False and mapping is performed?

[hashhar]

setting raw_results to True would cause to perform mapping, shouldn't it be the opposite?

Yes. The name change also means the logic needs to be inverted.

Or maybe I could add negation here, rename to raw_result and leave default value to False, so by default raw_result == False and mapping is performed?

This seems good to me.

@hovaesco / @mdesmet any opinion?

[hovaesco]

Sounds good to me, I'm not in favour of raw_results name, untyped_results is better or maybe legacy_untyped_results?

[mdesmet]

untyped seems a little weird as the results are always typed. Maybe legacy_primitive_types?

[hashhar]

are the results typed or are they always string?

[mdesmet]

The api only returns string or int. Other types are explicitly mapped.