fix(chip): Correct keyboard interaction (#1561)

Closes #1538
trimox · Nov 22, 2018 · 7d551c3 · 7d551c3
1 parent 14d0d8e
commit 7d551c3
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/chips/chip.ts b/packages/chips/chip.ts
@@ -259,7 +259,10 @@ export class MdcChip implements AfterViewInit, OnDestroy {
         }
       },
       eventTargetHasClass: (target: HTMLElement, className: string) => target.classList.contains(className),
-      notifyInteraction: () => this._emitSelectionChangeEvent(),
+      notifyInteraction: () => {
+        this.selected = !this.selected;
+        this._emitSelectionChangeEvent();
+      },
       notifyTrailingIconInteraction: () => this.trailingIconInteraction.emit({ detail: { chipId: this.id } }),
       notifyRemoval: () => this.removed.emit({ detail: { chipId: this.id, root: this } }),
       getComputedStyleValue: (propertyName: string) => {
@@ -277,7 +280,7 @@ export class MdcChip implements AfterViewInit, OnDestroy {
     beginExit(): void,
     setSelected(selected: boolean): void,
     setShouldRemoveOnTrailingIconClick(shouldRemove: boolean): void,
-    handleInteraction(evt: Event): void,
+    handleInteraction(evt: KeyboardEvent | MouseEvent): void,
     handleTransitionEnd(evt: TransitionEvent): void,
     handleTrailingIconInteraction(evt: Event): void
   } = new MDCChipFoundation(this.createAdapter());
@@ -319,8 +322,7 @@ export class MdcChip implements AfterViewInit, OnDestroy {
 
   private _loadListeners(): void {
     this._chipInteractionEventSubscription = this.chipInteractionEvents.pipe()
-      .subscribe(evt => {
-        this.selected = !this.selected;
+      .subscribe((evt: KeyboardEvent | MouseEvent) => {
         this._foundation.handleInteraction(evt);
       });