DLS should skip resolving when not configured

odacremolbap · odacremolbap · commit 8a4ea42be269 · 2022-11-10T08:34:04.000+01:00
diff --git a/pkg/reconciler/trigger/reconciler.go b/pkg/reconciler/trigger/reconciler.go
@@ -95,6 +95,7 @@ func (r *Reconciler) resolveDLS(ctx context.Context, t *eventingv1alpha1.Trigger
 	if t.Spec.Delivery == nil || t.Spec.Delivery.DeadLetterSink == nil {
 		t.Status.DeadLetterSinkURI = nil
 		t.Status.MarkDeadLetterSinkNotConfigured()
+		return nil
 	}
 
 	if t.Spec.Delivery.DeadLetterSink.Ref != nil && t.Spec.Delivery.DeadLetterSink.Ref.Namespace == "" {

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ func (r Reconciler) resolveDLS(ctx context.Context, t eventingv1alpha1.Trigger`
`95`	`95`	`if t.Spec.Delivery == nil \|\| t.Spec.Delivery.DeadLetterSink == nil {`
`96`	`96`	`t.Status.DeadLetterSinkURI = nil`
`97`	`97`	`t.Status.MarkDeadLetterSinkNotConfigured()`
	`98`	`+ return nil`
`98`	`99`	`}`
`99`	`100`
`100`	`101`	`if t.Spec.Delivery.DeadLetterSink.Ref != nil && t.Spec.Delivery.DeadLetterSink.Ref.Namespace == "" {`