reconciler triggers even if not ready

Author: odacremolbap

pkg/reconciler/redisbroker/reconcile_secret.go

@@ -103,48 +103,52 @@ func (r *secretReconciler) buildConfigSecret(ctx context.Context, rb *eventingv1
 			"Failed to list triggers: %w", err)
 	}
 
-	// TODO triggers must have resolved the URI, check status.
-
 	cfg := &config.Config{}
 	for _, t := range triggers {
-		if !t.ReferencesBroker(rb) {
+		// Generate secret even if the trigger is not ready, as long as one of the URIs for target
+		// or DLS exist.
+		if !t.ReferencesBroker(rb) || (t.Status.TargetURI == nil && t.Status.DeadLetterSinkURI == nil) {
 			continue
 		}
 
-		target := ""
-		if t.Spec.Target.URI != nil {
-			target = t.Spec.Target.URI.String()
-			// } else {
-			// TODO resolve target to URL
+		targetURI := ""
+		if t.Status.TargetURI != nil {
+			targetURI = t.Status.TargetURI.String()
+		} else {
+			// Configure empty URL so that all requests go to DLS when the target is
+			// not ready.
+			targetURI = "http://"
 		}
 
-		// TODO convert DeliveryOptions
 		do := &config.DeliveryOptions{}
 		if t.Spec.Delivery != nil {
 			do.Retry = t.Spec.Delivery.Retry
 			do.BackoffDelay = t.Spec.Delivery.BackoffDelay
 
 			if t.Spec.Delivery.BackoffPolicy != nil {
+				var bop config.BackoffPolicyType
 				switch *t.Spec.Delivery.BackoffPolicy {
 				case duckv1.BackoffPolicyLinear:
-					*do.BackoffPolicy = config.BackoffPolicyLinear
+					bop = config.BackoffPolicyLinear
 
 				case duckv1.BackoffPolicyExponential:
-					*do.BackoffPolicy = config.BackoffPolicyExponential
+					bop = config.BackoffPolicyLinear
 				}
+				do.BackoffPolicy = &bop
 			}
 
-			// TODO resolve reference to URI
-			uri := t.Spec.Delivery.DeadLetterSink.URI.String()
-			do.DeadLetterURL = &uri
+			if t.Status.DeadLetterSinkURI != nil {
+				uri := t.Status.DeadLetterSinkURI.String()
+				do.DeadLetterURL = &uri
+			}
 		}
 
 		trg := config.Trigger{
 			Name:    t.Name,
 			Filters: t.Spec.Filters,
 			Targets: []config.Target{
 				{
-					URL:             target,
+					URL:             targetURI,
 					DeliveryOptions: do,
 				},
 			},

pkg/reconciler/trigger/reconciler.go

@@ -102,14 +102,14 @@ func (r *Reconciler) resolveDLS(ctx context.Context, t *eventingv1alpha1.Trigger
 	dlsURI, err := r.uriResolver.URIFromDestinationV1(ctx, *t.Spec.Delivery.DeadLetterSink, t)
 	if err != nil {
 		logging.FromContext(ctx).Errorw("Unable to get the dead letter sink's URI", zap.Error(err))
-		t.Status.MarkTargetResolvedFailed("Unable to get the dead letter sink's URI", "%v", err)
+		t.Status.MarkDeadLetterSinkResolvedFailed("Unable to get the dead letter sink's URI", "%v", err)
 		t.Status.TargetURI = nil
 		return pkgreconciler.NewEvent(corev1.EventTypeWarning, reconciler.ReasonFailedResolveReference,
 			"Failed to get dead letter sink's URI: %w", err)
 	}
 
 	t.Status.DeadLetterSinkURI = dlsURI
-	t.Status.MarkDeadLetterSinkNotConfigured()
+	t.Status.MarkDeadLetterSinkResolvedSucceeded()
 
 	return nil
 }