Skip to content
This repository was archived by the owner on Dec 11, 2023. It is now read-only.

Commit 55674e3

Browse files
author
odacremolbap
committed
add addressable status
1 parent 62cf2a2 commit 55674e3

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

pkg/apis/eventing/v1alpha1/redisbroker_lifecycle.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ var redisBrokerCondSet = apis.NewLivingConditionSet(
3737
RedisBrokerBrokerService,
3838
RedisBrokerBrokerServiceEndpointsConditionReady,
3939
RedisBrokerConfigSecret,
40-
41-
// TODO RedisBrokerConditionAddressable,
40+
RedisBrokerConditionAddressable,
4241
)
4342
var redisBrokerCondSetLock = sync.RWMutex{}
4443

pkg/reconciler/redisbroker/reconciler.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ import (
99
"go.uber.org/zap"
1010
"k8s.io/client-go/kubernetes"
1111

12+
"knative.dev/pkg/apis"
1213
"knative.dev/pkg/logging"
14+
"knative.dev/pkg/network"
1315
"knative.dev/pkg/reconciler"
1416

1517
eventingv1alpha1 "github.com/triggermesh/triggermesh-core/pkg/apis/eventing/v1alpha1"
@@ -32,22 +34,25 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, rb *eventingv1alpha1.Red
3234
logging.FromContext(ctx).Infow("Reconciling", zap.Any("Broker", *rb))
3335

3436
// Make sure the Redis deployment and service exists.
35-
_, svc, err := r.redisReconciler.reconcile(ctx, rb)
37+
_, redisSvc, err := r.redisReconciler.reconcile(ctx, rb)
3638
if err != nil {
3739
return err
3840
}
3941

40-
// Iterate triggers and create secret
42+
// Iterate triggers and create secret.
4143
secret, err := r.secretReconciler.reconcile(ctx, rb)
4244
if err != nil {
4345
return err
4446
}
4547

4648
// Make sure the Broker deployment for Redis exists and that it points to the Redis service.
47-
_, _, err = r.brokerReconciler.reconcile(ctx, rb, svc, secret)
49+
_, _, err = r.brokerReconciler.reconcile(ctx, rb, redisSvc, secret)
4850
if err != nil {
4951
return err
5052
}
5153

54+
// Set address to the Redis service.
55+
rb.Status.SetAddress(apis.HTTP(network.GetServiceHostname(redisSvc.Name, redisSvc.Namespace)))
56+
5257
return nil
5358
}

0 commit comments

Comments
 (0)