use common broker reconciler

Author: odacremolbap

pkg/apis/eventing/v1alpha1/interfaces.go

@@ -1,18 +1,32 @@
 package v1alpha1
 
 import (
+	"context"
+
+	appsv1 "k8s.io/api/apps/v1"
 	"knative.dev/pkg/kmeta"
 )
 
+type Broker struct {
+	Port *int `json:"port,omitempty"`
+
+	Observability *Observability `json:"observability,omitempty"`
+}
+
+type Observability struct {
+	ValueFromConfigMap string `json:"valueFromConfigMap"`
+}
+
 type ReconcilableBroker interface {
 	kmeta.OwnerRefable
 
 	GetReconcilableBrokerStatus() ReconcilableBrokerStatus
 	GetOwnedObjectsSuffix() string
+	GetReconcilableBrokerSpec() *Broker
 }
 
 type ReconcilableBrokerStatus interface {
-	// Secret status management.
+	// Secret as config status management.
 	MarkConfigSecretFailed(reason, messageFormat string, messageA ...interface{})
 	MarkConfigSecretReady()
 
@@ -23,4 +37,17 @@ type ReconcilableBrokerStatus interface {
 	// RoleBinding status management.
 	MarkBrokerRoleBindingFailed(reason, messageFormat string, messageA ...interface{})
 	MarkBrokerRoleBindingReady()
+
+	// Broker Deployment status management.
+	MarkBrokerDeploymentFailed(reason, messageFormat string, messageA ...interface{})
+	PropagateBrokerDeploymentAvailability(ctx context.Context, ds *appsv1.DeploymentStatus)
+
+	// Broker Service status management
+	MarkBrokerServiceFailed(reason, messageFormat string, messageA ...interface{})
+	MarkBrokerServiceReady()
+
+	// Broker Endpoints status management.
+	MarkBrokerEndpointsTrue()
+	MarkBrokerEndpointsUnknown(reason, messageFormat string, messageA ...interface{})
+	MarkBrokerEndpointsFailed(reason, messageFormat string, messageA ...interface{})
 }

pkg/apis/eventing/v1alpha1/memory_lifecycle.go

@@ -49,6 +49,11 @@ func (t *MemoryBroker) GetStatus() *duckv1.Status {
 	return &t.Status.Status
 }
 
+// GetReconcilableBrokerSpec returns the all brokers common Broker spec.
+func (t *MemoryBroker) GetReconcilableBrokerSpec() *Broker {
+	return &t.Spec.Broker
+}
+
 // GetReconcilableBrokerStatus returns a status interface that allows generic reconciler
 // to manage it.
 func (t *MemoryBroker) GetReconcilableBrokerStatus() ReconcilableBrokerStatus {

pkg/apis/eventing/v1alpha1/redisbroker_lifecycle.go

@@ -57,6 +57,11 @@ func (t *RedisBroker) GetStatus() *duckv1.Status {
 	return &t.Status.Status
 }
 
+// GetReconcilableBrokerSpec returns the all brokers common Broker spec.
+func (t *RedisBroker) GetReconcilableBrokerSpec() *Broker {
+	return &t.Spec.Broker
+}
+
 // GetReconcilableBrokerStatus returns a status interface that allows generic reconciler
 // to manage it.
 func (t *RedisBroker) GetReconcilableBrokerStatus() ReconcilableBrokerStatus {
@@ -217,7 +222,6 @@ func (bs *RedisBrokerStatus) MarkRedisEndpointsTrue() {
 
 // Manage Redis broker state for
 // Deployment, Service and Endpoint
-
 func (bs *RedisBrokerStatus) MarkBrokerDeploymentFailed(reason, messageFormat string, messageA ...interface{}) {
 	redisBrokerCondSet.Manage(bs).MarkFalse(RedisBrokerBrokerDeployment, reason, messageFormat, messageA...)
 }

pkg/apis/eventing/v1alpha1/redisbroker_types.go

@@ -76,16 +76,6 @@ type SecretValueFromSource struct {
 	SecretKeyRef corev1.SecretKeySelector `json:"secretKeyRef,omitempty"`
 }
 
-type Broker struct {
-	Port *int `json:"port,omitempty"`
-
-	Observability *Observability `json:"observability,omitempty"`
-}
-
-type Observability struct {
-	ValueFromConfigMap string `json:"valueFromConfigMap"`
-}
-
 type RedisBrokerSpec struct {
 	Redis *Redis `json:"redis,omitempty"`