add memorybroker deletion test

Author: odacremolbap

pkg/reconciler/memorybroker/reconciler_test.go

@@ -3,6 +3,7 @@ package memorybroker
 import (
 	"context"
 	"testing"
+	"time"
 
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
@@ -19,6 +20,7 @@ import (
 	fakeeventingclient "github.com/triggermesh/triggermesh-core/pkg/client/generated/injection/client/fake"
 	"github.com/triggermesh/triggermesh-core/pkg/client/generated/injection/reconciler/eventing/v1alpha1/memorybroker"
 	"github.com/triggermesh/triggermesh-core/pkg/reconciler/common"
+	"github.com/triggermesh/triggermesh-core/pkg/reconciler/resources"
 	tmt "github.com/triggermesh/triggermesh-core/pkg/reconciler/testing"
 	tmtv1alpha1 "github.com/triggermesh/triggermesh-core/pkg/reconciler/testing/v1alpha1"
 )
@@ -34,6 +36,7 @@ var (
 	tKey            = tNamespace + "/" + tName
 	tTrue           = true
 	tReplicas int32 = 1
+	tNow            = metav1.NewTime(time.Now())
 )
 
 func TestAllCases(t *testing.T) {
@@ -62,6 +65,16 @@ func TestAllCases(t *testing.T) {
 			WantEvents: []string{
 				knt.Eventf(corev1.EventTypeWarning, "UnavailableEndpoints", `Endpoints for broker service "`+tNamespace+`/`+tName+`-mb-broker" do not exist`),
 			},
+		}, {
+			Name: "deleting broker",
+			Key:  tKey,
+			Objects: []runtime.Object{
+				tmtv1alpha1.NewMemoryBroker(tNamespace, tName,
+					tmtv1alpha1.MemoryBrokerWithMetaOptions(resources.MetaSetDeletion(&tNow))),
+			},
+			WantCreates: []runtime.Object{
+				// Reconciliation is skipped and no objects are created.
+			},
 		},
 	}
 

pkg/reconciler/resources/meta.go

@@ -58,3 +58,9 @@ func MetaAddLabel(key, value string) MetaOption {
 		m.Labels[key] = value
 	}
 }
+
+func MetaSetDeletion(t *metav1.Time) MetaOption {
+	return func(m *metav1.ObjectMeta) {
+		m.DeletionTimestamp = t
+	}
+}

pkg/reconciler/resources/meta_test.go

@@ -5,13 +5,18 @@ package resources
 
 import (
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+var (
+	tNow = metav1.NewTime(time.Now())
+)
+
 func TestNewMeta(t *testing.T) {
 	testCases := map[string]struct {
 		options  []MetaOption
@@ -50,6 +55,15 @@ func TestNewMeta(t *testing.T) {
 					"key1": "label1",
 				},
 			}},
+		"with deletion": {
+			options: []MetaOption{
+				MetaSetDeletion(&tNow),
+			},
+			expected: metav1.ObjectMeta{
+				Name:              tName,
+				Namespace:         tNamespace,
+				DeletionTimestamp: &tNow,
+			}},
 	}
 
 	for name, tc := range testCases {

pkg/reconciler/testing/v1alpha1/memorybroker.go

@@ -4,6 +4,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
 	eventingv1alpha1 "github.com/triggermesh/triggermesh-core/pkg/apis/eventing/v1alpha1"
+	"github.com/triggermesh/triggermesh-core/pkg/reconciler/resources"
 )
 
 // MemoryBrokerOption enables further configuration of a v1alpha1.MemoryBroker.
@@ -25,3 +26,11 @@ func NewMemoryBroker(namespace, name string, opts ...MemoryBrokerOption) *eventi
 
 	return b
 }
+
+func MemoryBrokerWithMetaOptions(opts ...resources.MetaOption) MemoryBrokerOption {
+	return func(d *eventingv1alpha1.MemoryBroker) {
+		for _, opt := range opts {
+			opt(&d.ObjectMeta)
+		}
+	}
+}