Skip to content
This repository was archived by the owner on May 9, 2023. It is now read-only.

Commit f71f21d

Browse files
committed
Failing tests fixed
1 parent 84f1968 commit f71f21d

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

pkg/file/file_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ func TestIsGit(t *testing.T) {
6868
{"https://github.com/triggermesh/tm.git", true},
6969
{"https://github.com/triggermesh/tm", true},
7070
{"github.com/triggermesh/tm", true},
71-
{"git@github.com:triggermesh/tm.git", true},
72-
{"https://triggermesh.com/", true}, //should not be true?
71+
{"https://triggermesh.com/", false},
72+
{"some-random-string", false},
7373
}
7474
for _, tc := range testCases {
7575
result := IsGit(tc.path)
76-
assert.Equal(t, tc.result, result)
76+
assert.Equal(t, tc.result, result, "isGit(%s) expected to be %v, got %v", tc.path, tc.result, result)
7777
}
7878
}
7979

pkg/resources/service/service_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ func TestDeployAndDelete(t *testing.T) {
8080

8181
client.Dry = false
8282
client.Wait = true
83+
client.Debug = true
8384
serviceClient, err := client.NewClient(client.ConfigPath(""))
8485
assert.NoError(t, err)
8586

@@ -105,6 +106,7 @@ func TestDeployAndDelete(t *testing.T) {
105106
address = addr.Host + ":80"
106107
default:
107108
t.Error("malformed service URL scheme", addr.Scheme)
109+
return
108110
}
109111
conn, err := net.DialTimeout("tcp", address, dialTimeout)
110112
assert.NoError(t, err)

0 commit comments

Comments
 (0)