Added engine worker immediatePollIntervalMs and limit env vars

[matt-aitken]

Summary by CodeRabbit

• New Features
  • Enhanced background processing settings with new options to adjust concurrent operations and polling intervals, offering improved performance and reliability for task handling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request enhances configuration for the run engine by adding two new environment properties and integrating them into the run engine setup. The changes in env.server.ts define RUN_ENGINE_WORKER_CONCURRENCY_LIMIT and RUN_ENGINE_WORKER_IMMEDIATE_POLL_INTERVAL with default values. These values are then passed to the run engine during its creation in runEngine.server.ts to control worker concurrency and immediate polling intervals.

Changes

File(s)	Change Summary
apps/webapp/app/env.server.ts	Added two new properties to EnvironmentSchema: - RUN_ENGINE_WORKER_CONCURRENCY_LIMIT (default: 10) - RUN_ENGINE_WORKER_IMMEDIATE_POLL_INTERVAL (default: 100)
apps/webapp/app/v3/runEngine.server.ts	Updated createRunEngine to use the new environmental properties for worker configuration by passing env.RUN_ENGINE_WORKER_IMMEDIATE_POLL_INTERVAL and env.RUN_ENGINE_WORKER_CONCURRENCY_LIMIT

Sequence Diagram(s)

sequenceDiagram
    participant E as Environment (env.server.ts)
    participant R as RunEngine (runEngine.server.ts)
    participant W as Worker Process

    E->>R: Provide RUN_ENGINE_WORKER_CONCURRENCY_LIMIT
    E->>R: Provide RUN_ENGINE_WORKER_IMMEDIATE_POLL_INTERVAL
    R->>W: Initialize worker with limit and polling interval
    W->>R: Confirm configuration applied

Loading

Possibly related PRs

• re2: Add attempt metrics in dev (prod WIP). Added max concurrent runs setting to dev using p-limit #1766: Added new properties to EnvironmentSchema for worker concurrency configuration.
• When deploying, batch the "Waiting for deploy runs #1693: Enhanced configuration options for the run engine via updates in EnvironmentSchema.
• More v1 run engine fixes #1644: Introduced environmental property settings that are now mirrored in the run engine setup.

Poem

I'm a rabbit with a hop and a beat,
Configuration changes sure can't be beat!
New environment vars lead the way, 🍃
Guiding workers with precision each day.
With hops and codes, I cheer aloud,
These changes make our app truly proud!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72d9877 and 3d7cf07.

📒 Files selected for processing (2)

• apps/webapp/app/env.server.ts (1 hunks)
• apps/webapp/app/v3/runEngine.server.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.