Skip to content

Side menu and Org dropdown improvements #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 18, 2025
Merged

Side menu and Org dropdown improvements #1801

merged 10 commits into from
Mar 18, 2025

Conversation

samejr
Copy link
Member

@samejr samejr commented Mar 18, 2025

  • Made the hover states of the Settings and Usage button better
  • Simplified the Dev Disconnected modal buttons by adding an inline link to the docs instead
  • Improved the layout of the Org name and the spacing of the Plan and Members links
  • Fixed the divide line not showing when the menu needs to scroll

CleanShot 2025-03-18 at 18 46 17@2x
CleanShot 2025-03-18 at 18 28 09
CleanShot 2025-03-18 at 18 27 51

Summary by CodeRabbit

  • New Features

    • Command interface panels now support an optional title, offering enhanced contextual clarity.
  • Style

    • Updated the notification banner with an accent button styling.
    • Refined the navigation menu with improved text sizes, spacing, and layout adjustments.
    • Introduced smoother transition animations for expandable sections.
    • Streamlined the dropdown icon appearance for a more consistent look.
    • Enhanced developer connection guidance with clearer, well-formatted instructions.
    • Upgraded the icon library for improved visual consistency.
    • Adjusted button styling in the impersonation banner.

Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 3ff5782

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "proxy" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

coderabbitai bot commented Mar 18, 2025

Walkthrough

This pull request introduces several modifications across various React components within the web application. Changes include reorganizing and consolidating import statements, updating component styling via new class names, and refining UI behavior. In particular, the SetupCommands components have been enhanced with an optional title prop that alters their rendering logic, while navigation components see adjustments to transition animations and UI text. Import paths have also been updated in some components, with redundant imports removed.

Changes

Files Change Summary
apps/.../ImpersonationBanner.tsx, apps/.../primitives/Avatar.tsx, apps/.../primitives/Popover.tsx Removed unused imports, updated icon import paths, added new styling classes, and simplified conditional class names (eliminating dynamic scaling in Popover).
apps/.../SetupCommands.tsx Introduced an optional title prop for InitCommandV3, TriggerDevStepV3, and TriggerLoginStepV3, added conditional rendering for the title alongside tabs, updated the ClipboardField variant, and added a new import for Header3.
apps/.../navigation/EnvironmentSelector.tsx, apps/.../navigation/SideMenu.tsx, apps/.../navigation/SideMenuSection.tsx Reorganized and consolidated import statements, updated styling and class names (including layout adjustments and text variants), refined UI instructions and formatting in dialogs, and modified transition easing functions for smoother animations.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as SetupCommands Component
    participant T as Title Renderer
    participant R as Tabs Renderer

    U->>C: Render component (with/without title)
    alt Title provided
        C->>T: Render title block
        C->>R: Render tab list with adjusted margin
    else No title provided
        C->>R: Render tab list normally
    end
Loading

Possibly related PRs

  • An improved 404 page design #1427: The changes in the main PR regarding the ImpersonationBanner.tsx file, specifically the removal of the Paragraph import, are related to the retrieved PR which also involves the Paragraph component in the ErrorDisplay.tsx file, indicating a shared context of component usage.

Suggested reviewers

  • matt-aitken
  • ericallam

Poem

I'm a rabbit hopping with delight,
In code fields updated, my heart feels light.
New titles and styles now grace the day,
With imports and transitions in a merry array.
Hopping on changes, I cheer with all my might! 🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a6c332 and 3ff5782.

📒 Files selected for processing (1)
  • apps/webapp/app/components/navigation/SideMenu.tsx (9 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/webapp/app/components/navigation/SideMenu.tsx
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-aitken matt-aitken merged commit a6e85f0 into main Mar 18, 2025
12 checks passed
@matt-aitken matt-aitken deleted the side-menu-tweaks branch March 18, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants