-
-
Notifications
You must be signed in to change notification settings - Fork 748
Add scheduled at timestamp to created run containers #1722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes add a new environment variable, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DockerTaskOperations
participant execa
participant DockerContainer
User->>DockerTaskOperations: call create()
DockerTaskOperations->>Date: generate SCHEDULED_AT_MS using Date.now()
DockerTaskOperations->>execa: invoke Docker command with SCHEDULED_AT_MS in runArgs
execa->>DockerContainer: launch container with the provided environment variable
sequenceDiagram
participant User
participant KubernetesTaskOperations
participant Pod
User->>KubernetesTaskOperations: call getSharedEnv()
KubernetesTaskOperations->>Date: generate SCHEDULED_AT_MS using Date.now().toString()
KubernetesTaskOperations->>Pod: launch pod with shared environment including SCHEDULED_AT_MS
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This will allow us to show more detailed metrics and debug cold starts better.
Summary by CodeRabbit