Skip to content

Add scheduled at timestamp to created run containers #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented Feb 20, 2025

This will allow us to show more detailed metrics and debug cold starts better.

Summary by CodeRabbit

  • New Features
    • Introduced a new environment configuration that passes the scheduled timestamp for containerized tasks.
    • Both container providers now include a timing parameter during task execution, ensuring tasks receive up-to-date scheduling details without impacting existing functionality.

Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: 3c76444

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Feb 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes add a new environment variable, SCHEDULED_AT_MS, to both the Docker and Kubernetes provider implementations. In the Docker provider’s create method and the Kubernetes provider’s getSharedEnv method, the variable is set to the current timestamp (using Date.now() or Date.now().toString()) and passed along with other environment variables. No existing logic or exports were altered.

Changes

File(s) Change Summary
apps/docker-provider/src/index.ts, apps/kubernetes-provider/src/index.ts Added a new environment variable SCHEDULED_AT_MS (using Date.now()/Date.now().toString()) to pass the current timestamp in the container/pod environment.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DockerTaskOperations
    participant execa
    participant DockerContainer

    User->>DockerTaskOperations: call create()
    DockerTaskOperations->>Date: generate SCHEDULED_AT_MS using Date.now()
    DockerTaskOperations->>execa: invoke Docker command with SCHEDULED_AT_MS in runArgs
    execa->>DockerContainer: launch container with the provided environment variable
Loading
sequenceDiagram
    participant User
    participant KubernetesTaskOperations
    participant Pod

    User->>KubernetesTaskOperations: call getSharedEnv()
    KubernetesTaskOperations->>Date: generate SCHEDULED_AT_MS using Date.now().toString()
    KubernetesTaskOperations->>Pod: launch pod with shared environment including SCHEDULED_AT_MS
Loading

Poem

In the code garden, I hop with delight,
A timestamp blooms, precise and bright.
SCHEDULED_AT_MS joins the fun,
Guiding containers when tasks are begun.
With whiskered joy and a bunny cheer,
I rap this fix for all to hear! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf43fd4 and 3c76444.

📒 Files selected for processing (2)
  • apps/docker-provider/src/index.ts (1 hunks)
  • apps/kubernetes-provider/src/index.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nicktrn nicktrn merged commit 80f2fc8 into main Feb 20, 2025
1 of 10 checks passed
@nicktrn nicktrn deleted the feat/scheduling-timestamp branch February 20, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant