Misc fixes related to error display

[nicktrn]

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced error handling for task runs, allowing for more specific error codes and improved communication of issues to users.
  • Introduced new error classes for better categorization of errors related to task execution and memory management.

• Bug Fixes

  • Improved accuracy in error messages related to environment variable fetching.
  • Simplified error handling by removing unnecessary cancellation logic during task run failures.

• Documentation

  • Updated error handling documentation to reflect new cases and classes introduced in this release.

[changeset-bot]

🦋 Changeset detected

Latest commit: b8ab892

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
trigger.dev	Patch
@trigger.dev/core	Patch
@trigger.dev/build	Patch
@trigger.dev/sdk	Patch
@internal/redis-worker	Patch
@internal/zod-worker	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch
@internal/testcontainers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance error handling across multiple components of the application. Key modifications include improved error reporting in the CrashTaskRunService, updates to error messages in the indexDeployment function, and the introduction of new error classes in the error handling module. Additionally, the cancellation logic during error handling in the ProdWorker class has been removed, simplifying the error management process. These updates collectively aim to provide clearer and more specific error information to users.

Changes

File Path	Change Summary
.changeset/sweet-spies-play.md	Introduced a patch for trigger.dev and @trigger.dev/core packages to improve error display during attempts and indexing processes.
apps/webapp/app/v3/services/crashTaskRun.server.ts	Enhanced error handling in CrashTaskRunService class; updated call method to utilize opts.errorCode, and modified #failAttempt method to include an optional code parameter in the error object.
packages/cli-v3/src/entryPoints/deploy-index-controller.ts	Updated error message in indexDeployment function to correctly reference $env.error when fetching environment variables.
packages/cli-v3/src/entryPoints/deploy-run-controller.ts	Removed cancellation of task run process in error handling of lazy attempt execution in ProdWorker class; adjusted logging statements accordingly.
packages/core/src/v3/errors.ts	Enhanced error handling with new error classes (TaskMetadataParseError, TaskIndexingImportError, etc.) and improved existing error handling logic, including modifications to exceptionEventEnhancer, taskRunErrorEnhancer, and serializeIndexingError.

Possibly related PRs

• v3: self-hosting support for latest packages #1319: Enhances error logging for index-related issues, directly related to the improvements in error handling introduced in the main PR.
• Prettier errors and related improvements #1387: Improves error handling and introduces new internal error reporting, aligning with the enhancements made in the main PR regarding error communication and handling.
• Fix dotenv overrides for dev runs #1388: Addresses the management of local environment variables, which may relate to overall error handling and configuration improvements in the main PR.

Suggested reviewers

• matt-aitken

Poem

🐇 In the garden where errors bloom,
We’ve tidied up the room,
With clearer messages to share,
No more worries, no despair.
Each task run now knows its fate,
Error codes that resonate! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.