Skip to content

Commit d11c5c7

Browse files
committed
Fix run replication telemetry by passing in a tracer
1 parent a815633 commit d11c5c7

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

apps/webapp/app/services/runsReplicationInstance.server.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { ClickHouse } from "@internal/clickhouse";
2-
import { RunsReplicationService } from "./runsReplicationService.server";
3-
import { singleton } from "~/utils/singleton";
42
import invariant from "tiny-invariant";
53
import { env } from "~/env.server";
6-
import { metricsRegister } from "~/metrics.server";
4+
import { singleton } from "~/utils/singleton";
5+
import { provider } from "~/v3/tracer.server";
76
import { logger } from "./logger.server";
7+
import { RunsReplicationService } from "./runsReplicationService.server";
88

99
export const runsReplicationInstance = singleton(
1010
"runsReplicationInstance",
@@ -49,6 +49,7 @@ function initializeRunsReplicationInstance() {
4949
leaderLockRetryIntervalMs: env.RUN_REPLICATION_LEADER_LOCK_RETRY_INTERVAL_MS,
5050
ackIntervalSeconds: env.RUN_REPLICATION_ACK_INTERVAL_SECONDS,
5151
logLevel: env.RUN_REPLICATION_LOG_LEVEL,
52+
tracer: provider.getTracer("runs-replication-service"),
5253
});
5354

5455
if (env.RUN_REPLICATION_ENABLED === "1") {

apps/webapp/app/v3/tracer.server.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class CustomWebappSampler implements Sampler {
8383
}
8484
}
8585

86-
export const { tracer, logger: otelLogger } = singleton("tracer", getTracer);
86+
export const { tracer, logger: otelLogger, provider } = singleton("tracer", getTracer);
8787

8888
export async function startActiveSpan<T>(
8989
name: string,
@@ -155,6 +155,7 @@ function getTracer() {
155155
return {
156156
tracer: trace.getTracer("trigger.dev", "3.3.12"),
157157
logger: logs.getLogger("trigger.dev", "3.3.12"),
158+
provider: new NodeTracerProvider(),
158159
};
159160
}
160161

@@ -260,6 +261,7 @@ function getTracer() {
260261
return {
261262
tracer: provider.getTracer("trigger.dev", "3.3.12"),
262263
logger: logs.getLogger("trigger.dev", "3.3.12"),
264+
provider,
263265
};
264266
}
265267

0 commit comments

Comments
 (0)