Skip to content

Commit bb7173b

Browse files
authored
Improve run replication logging (#2060)
* Remove the tcp buffer monitors * Improve run replication logging
1 parent 2aee3de commit bb7173b

File tree

4 files changed

+6
-169
lines changed

4 files changed

+6
-169
lines changed

apps/webapp/app/routes/admin.api.v1.runs-replication.start-monitor.ts

Lines changed: 0 additions & 59 deletions
This file was deleted.

apps/webapp/app/routes/admin.api.v1.runs-replication.stop-monitor.ts

Lines changed: 0 additions & 47 deletions
This file was deleted.

apps/webapp/app/services/monitorTcpBuffers.server.ts

Lines changed: 0 additions & 57 deletions
This file was deleted.

apps/webapp/app/services/runsReplicationService.server.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,15 +141,15 @@ export class RunsReplicationService {
141141
});
142142

143143
this._replicationClient.events.on("start", () => {
144-
this.logger.debug("Replication client started");
144+
this.logger.info("Replication client started");
145145
});
146146

147147
this._replicationClient.events.on("acknowledge", ({ lsn }) => {
148148
this.logger.debug("Acknowledged", { lsn });
149149
});
150150

151151
this._replicationClient.events.on("leaderElection", (isLeader) => {
152-
this.logger.debug("Leader election", { isLeader });
152+
this.logger.info("Leader election", { isLeader });
153153
});
154154
}
155155

@@ -360,7 +360,7 @@ export class RunsReplicationService {
360360
})
361361
.end();
362362

363-
this.logger.debug("handle_transaction", {
363+
this.logger.info("handle_transaction", {
364364
transaction: {
365365
xid: transaction.xid,
366366
commitLsn: transaction.commitLsn,
@@ -395,7 +395,7 @@ export class RunsReplicationService {
395395
this._lastAcknowledgedAt = now;
396396
this._lastAcknowledgedLsn = this._latestCommitEndLsn;
397397

398-
this.logger.debug("acknowledge_latest_transaction", {
398+
this.logger.info("acknowledge_latest_transaction", {
399399
commitEndLsn: this._latestCommitEndLsn,
400400
lastAcknowledgedAt: this._lastAcknowledgedAt,
401401
});
@@ -764,7 +764,7 @@ export class ConcurrentFlushScheduler<T> {
764764
span.setAttribute("concurrency_pending_count", this.concurrencyLimiter.pendingCount);
765765
span.setAttribute("concurrency_concurrency", this.concurrencyLimiter.concurrency);
766766

767-
this.logger.debug("flush_next_batch", {
767+
this.logger.info("flush_next_batch", {
768768
batchId,
769769
batchSize: batch.length,
770770
concurrencyActiveCount: this.concurrencyLimiter.activeCount,
@@ -796,7 +796,7 @@ export class ConcurrentFlushScheduler<T> {
796796

797797
this.failedBatchCount++;
798798
} else {
799-
this.logger.debug("flush_batch_complete", {
799+
this.logger.info("flush_batch_complete", {
800800
totalBatches: 1,
801801
successfulBatches: 1,
802802
failedBatches: 0,

0 commit comments

Comments
 (0)