Merge remote-tracking branch 'origin/main' into checkpoint-cleanup

Author: nicktrn

.changeset/three-olives-love.md

@@ -155,6 +155,10 @@ export const taskWithInitReturn = task({
 });
 ```
 
+<Info>
+Errors thrown in the `init` function are ignored.
+</Info>
+
 ### `cleanup` function
 
 This function is called after the `run` function is executed, regardless of whether the run was successful or not. It's useful for cleaning up resources, logging, or other side effects.
@@ -171,10 +175,18 @@ export const taskWithCleanup = task({
 });
 ```
 
+<Info>
+Errors thrown in the `cleanup` function will fail the attempt.
+</Info>
+
 ### `middleware` function
 
 This function is called before the `run` function, it allows you to wrap the run function with custom code.
 
+<Info>
+An error thrown in `middleware` is just like an uncaught error in the run function: it will propagate through to `handleError()` and then will fail the attempt (causing a retry).
+</Info>
+
 ### `onStart` function
 
 When a task run starts, the `onStart` function is called. It's useful for sending notifications, logging, and other side effects. This function will only be called one per run (not per retry). If you want to run code before each retry, use the `init` function.
@@ -204,6 +216,10 @@ export default defineConfig({
 });
 ```
 
+<Info>
+Errors thrown in the `onStart` function are ignored.
+</Info>
+
 ### `onSuccess` function
 
 When a task run succeeds, the `onSuccess` function is called. It's useful for sending notifications, logging, syncing state to your database, or other side effects.
@@ -233,6 +249,10 @@ export default defineConfig({
 });
 ```
 
+<Info>
+Errors thrown in the `onSuccess` function are ignored.
+</Info>
+
 ### `onFailure` function
 
 When a task run fails, the `onFailure` function is called. It's useful for sending notifications, logging, or other side effects. It will only be executed once the task run has exhausted all its retries.
@@ -262,12 +282,20 @@ export default defineConfig({
 });
 ```
 
+<Info>
+Errors thrown in the `onFailure` function are ignored.
+</Info>
+
 ### `handleError` functions
 
 You can define a function that will be called when an error is thrown in the `run` function, that allows you to control how the error is handled and whether the task should be retried.
 
 Read more about `handleError` in our [Errors and Retrying guide](/errors-retrying).
 
+<Info>
+Uncaught errors will throw a special internal error of the type `HANDLE_ERROR_ERROR`.
+</Info>
+
 ## Next steps
 
 <CardGroup>

docs/tasks/overview.mdx

@@ -1,5 +1,12 @@
 # @trigger.dev/build
 
+## 3.0.9
+
+### Patch Changes
+
+- Updated dependencies:
+  - `@trigger.dev/core@3.0.9`
+
 ## 3.0.8
 
 ### Patch Changes

packages/build/CHANGELOG.md

@@ -1,6 +1,6 @@
 {
   "name": "@trigger.dev/build",
-  "version": "3.0.8",
+  "version": "3.0.9",
   "description": "trigger.dev build extensions",
   "license": "MIT",
   "publishConfig": {
@@ -65,7 +65,7 @@
     "check-exports": "attw --pack ."
   },
   "dependencies": {
-    "@trigger.dev/core": "workspace:3.0.8",
+    "@trigger.dev/core": "workspace:3.0.9",
     "pkg-types": "^1.1.3",
     "tinyglobby": "^0.2.2",
     "tsconfck": "3.1.3"

packages/build/package.json

@@ -1,5 +1,13 @@
 # trigger.dev
 
+## 3.0.9
+
+### Patch Changes
+
+- Updated dependencies:
+  - `@trigger.dev/core@3.0.9`
+  - `@trigger.dev/build@3.0.9`
+
 ## 3.0.8
 
 ### Patch Changes

packages/cli-v3/CHANGELOG.md

@@ -1,6 +1,6 @@
 {
   "name": "trigger.dev",
-  "version": "3.0.8",
+  "version": "3.0.9",
   "description": "A Command-Line Interface for Trigger.dev (v3) projects",
   "type": "module",
   "license": "MIT",
@@ -87,8 +87,8 @@
     "@opentelemetry/sdk-trace-base": "1.25.1",
     "@opentelemetry/sdk-trace-node": "1.25.1",
     "@opentelemetry/semantic-conventions": "1.25.1",
-    "@trigger.dev/build": "workspace:3.0.8",
-    "@trigger.dev/core": "workspace:3.0.8",
+    "@trigger.dev/build": "workspace:3.0.9",
+    "@trigger.dev/core": "workspace:3.0.9",
     "c12": "^1.11.1",
     "chalk": "^5.2.0",
     "cli-table3": "^0.6.3",

packages/cli-v3/package.json

@@ -1,5 +1,11 @@
 # internal-platform
 
+## 3.0.9
+
+### Patch Changes
+
+- fix: run metadata not working when using npx/pnpm dlx ([`4c1ee3d6e`](https://github.com/triggerdotdev/trigger.dev/commit/4c1ee3d6ea5f2e1dfc9f475c99ecd236bf780a19))
+
 ## 3.0.8
 
 ### Patch Changes

packages/core/CHANGELOG.md

@@ -1,6 +1,6 @@
 {
   "name": "@trigger.dev/core",
-  "version": "3.0.8",
+  "version": "3.0.9",
   "description": "Core code used across the Trigger.dev SDK and platform",
   "license": "MIT",
   "publishConfig": {

packages/core/package.json

@@ -1,11 +1,13 @@
 import { DeserializedJson } from "../../schemas/json.js";
 import { apiClientManager } from "../apiClientManager-api.js";
 import { taskContext } from "../task-context-api.js";
+import { getGlobal, registerGlobal } from "../utils/globals.js";
 import { ApiRequestOptions } from "../zodfetch.js";
 
+const API_NAME = "run-metadata";
+
 export class RunMetadataAPI {
   private static _instance?: RunMetadataAPI;
-  private store: Record<string, DeserializedJson> | undefined;
 
   private constructor() {}
 
@@ -17,8 +19,16 @@ export class RunMetadataAPI {
     return this._instance;
   }
 
+  get store(): Record<string, DeserializedJson> | undefined {
+    return getGlobal(API_NAME);
+  }
+
+  set store(value: Record<string, DeserializedJson> | undefined) {
+    registerGlobal(API_NAME, value, true);
+  }
+
   public enterWithMetadata(metadata: Record<string, DeserializedJson>): void {
-    this.store = metadata;
+    registerGlobal(API_NAME, metadata);
   }
 
   public current(): Record<string, DeserializedJson> | undefined {

packages/core/src/v3/runMetadata/index.ts

@@ -1,3 +1,4 @@
+import { DeserializedJson } from "../../schemas/json.js";
 import { ApiClientConfiguration } from "../apiClientManager/types.js";
 import { Clock } from "../clock/clock.js";
 import type { RuntimeManager } from "../runtime/manager.js";
@@ -54,4 +55,5 @@ type TriggerDotDevGlobalAPI = {
   ["task-catalog"]?: TaskCatalog;
   ["task-context"]?: TaskContext;
   ["api-client"]?: ApiClientConfiguration;
+  ["run-metadata"]?: Record<string, DeserializedJson>;
 };

packages/core/src/v3/utils/globals.ts

@@ -1,5 +1,13 @@
 # @trigger.dev/sdk
 
+## 3.0.9
+
+### Patch Changes
+
+- Removed the inline-code accessory from the logs when calling trigger or batchTrigger from a run ([#1364](https://github.com/triggerdotdev/trigger.dev/pull/1364))
+- Updated dependencies:
+  - `@trigger.dev/core@3.0.9`
+
 ## 3.0.8
 
 ### Patch Changes

packages/trigger-sdk/CHANGELOG.md

@@ -1,6 +1,6 @@
 {
   "name": "@trigger.dev/sdk",
-  "version": "3.0.8",
+  "version": "3.0.9",
   "description": "trigger.dev Node.JS SDK",
   "license": "MIT",
   "publishConfig": {
@@ -48,7 +48,7 @@
     "@opentelemetry/api": "1.9.0",
     "@opentelemetry/api-logs": "0.52.1",
     "@opentelemetry/semantic-conventions": "1.25.1",
-    "@trigger.dev/core": "workspace:3.0.8",
+    "@trigger.dev/core": "workspace:3.0.9",
     "chalk": "^5.2.0",
     "cronstrue": "^2.21.0",
     "debug": "^4.3.4",

packages/trigger-sdk/package.json

@@ -19,6 +19,8 @@ export const runMetadataTask = task({
 export const runMetadataChildTask = task({
   id: "run-metadata-child-task",
   run: async (payload: any, { ctx }) => {
+    logger.info("metadata", { metadata: metadata.current() });
+
     await metadata.set("child", "task");
 
     logger.info("metadata", { metadata: metadata.current() });