Actually set the timed out runs to status = TIMED_OUT

Author: ericallam

apps/webapp/app/components/primitives/Select.tsx

@@ -613,7 +613,7 @@ export function SelectPopover({
         "z-50 flex flex-col overflow-clip rounded border border-charcoal-700 bg-background-bright shadow-md outline-none animate-in fade-in-40",
         "min-w-[max(180px,calc(var(--popover-anchor-width)+0.5rem))]",
         "max-w-[min(480px,var(--popover-available-width))]",
-        "max-h-[min(480px,var(--popover-available-height))]",
+        "max-h-[min(520px,var(--popover-available-height))]",
         "origin-[var(--popover-transform-origin)]",
         className
       )}

apps/webapp/app/components/runs/v3/TaskRunStatus.tsx

@@ -28,6 +28,7 @@ export const allTaskRunStatuses = [
   "COMPLETED_SUCCESSFULLY",
   "CANCELED",
   "COMPLETED_WITH_ERRORS",
+  "TIMED_OUT",
   "CRASHED",
   "PAUSED",
   "INTERRUPTED",
@@ -45,6 +46,7 @@ export const filterableTaskRunStatuses = [
   "COMPLETED_SUCCESSFULLY",
   "CANCELED",
   "COMPLETED_WITH_ERRORS",
+  "TIMED_OUT",
   "CRASHED",
   "INTERRUPTED",
   "SYSTEM_FAILURE",

apps/webapp/app/components/runs/v3/TaskRunsTable.tsx

@@ -39,9 +39,16 @@ import {
 import { CancelRunDialog } from "./CancelRunDialog";
 import { LiveTimer } from "./LiveTimer";
 import { ReplayRunDialog } from "./ReplayRunDialog";
-import { TaskRunStatusCombo } from "./TaskRunStatus";
+import {
+  descriptionForTaskRunStatus,
+  filterableTaskRunStatuses,
+  runStatusTitle,
+  TaskRunStatusCombo,
+  TaskRunStatusIcon,
+} from "./TaskRunStatus";
 import { RunTag } from "./RunTag";
 import { Badge } from "~/components/primitives/Badge";
+import { SimpleTooltip } from "~/components/primitives/Tooltip";
 
 type RunsTableProps = {
   total: number;
@@ -126,7 +133,24 @@ export function TaskRunsTable({
           <TableHeaderCell>Env</TableHeaderCell>
           <TableHeaderCell>Task</TableHeaderCell>
           <TableHeaderCell>Version</TableHeaderCell>
-          <TableHeaderCell>Status</TableHeaderCell>
+          <TableHeaderCell
+            tooltip={
+              <div className="flex max-w-xs flex-col gap-3 p-1">
+                {filterableTaskRunStatuses.map((status) => (
+                  <div>
+                    <div className="mb-0.5 flex items-center gap-1.5">
+                      <TaskRunStatusCombo status={status} />
+                    </div>
+                    <Paragraph variant="extra-small" className="!text-wrap text-text-dimmed">
+                      {descriptionForTaskRunStatus(status)}
+                    </Paragraph>
+                  </div>
+                ))}
+              </div>
+            }
+          >
+            Status
+          </TableHeaderCell>
           <TableHeaderCell>Started</TableHeaderCell>
           <TableHeaderCell
             colSpan={3}
@@ -287,7 +311,10 @@ export function TaskRunsTable({
                 </TableCell>
                 <TableCell to={path}>{run.version ?? "–"}</TableCell>
                 <TableCell to={path}>
-                  <TaskRunStatusCombo status={run.status} />
+                  <SimpleTooltip
+                    content={descriptionForTaskRunStatus(run.status)}
+                    button={<TaskRunStatusCombo status={run.status} />}
+                  />
                 </TableCell>
                 <TableCell to={path}>
                   {run.startedAt ? <DateTime date={run.startedAt} /> : "–"}

apps/webapp/app/v3/services/completeAttempt.server.ts

@@ -363,10 +363,16 @@ export class CompleteAttemptService extends BaseService {
           },
         });
 
+        const status =
+          sanitizedError.type === "INTERNAL_ERROR" &&
+          sanitizedError.code === "MAX_DURATION_EXCEEDED"
+            ? "TIMED_OUT"
+            : "COMPLETED_WITH_ERRORS";
+
         const finalizeService = new FinalizeTaskRunService();
         await finalizeService.call({
           id: taskRunAttempt.taskRunId,
-          status: "COMPLETED_WITH_ERRORS",
+          status,
           completedAt: new Date(),
         });
       }

apps/webapp/app/v3/taskStatus.ts

@@ -41,6 +41,7 @@ export const FINAL_RUN_STATUSES = [
   "SYSTEM_FAILURE",
   "EXPIRED",
   "CRASHED",
+  "TIMED_OUT",
 ] satisfies TaskRunStatus[];
 
 export type FINAL_RUN_STATUSES = (typeof FINAL_RUN_STATUSES)[number];
@@ -96,6 +97,7 @@ export const FAILED_RUN_STATUSES = [
   "COMPLETED_WITH_ERRORS",
   "SYSTEM_FAILURE",
   "CRASHED",
+  "TIMED_OUT",
 ] satisfies TaskRunStatus[];
 
 export function isFailedRunStatus(status: TaskRunStatus): boolean {

references/hello-world/src/trigger/example.ts

@@ -45,10 +45,18 @@ export const childTask = task({
 
 export const maxDurationTask = task({
   id: "max-duration",
-  run: async (payload: { sleepFor: number }, { signal }) => {
+  retry: {
+    maxAttempts: 5,
+    minTimeoutInMs: 1_000,
+    maxTimeoutInMs: 2_000,
+    factor: 1.4,
+  },
+  run: async (payload: { sleepFor: number }, { signal, ctx }) => {
     await setTimeout(payload.sleepFor * 1000, { signal });
 
-    return usage.getCurrent();
+    if (ctx.attempt.number < 5) {
+      throw new Error("Example error");
+    }
   },
 });