Skip to content

add gzprintf #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

add gzprintf #376

merged 1 commit into from
Jun 4, 2025

Conversation

@folkertdev
Copy link
Member

@folkertdev folkertdev commented May 31, 2025

No description provided.

@codecov
Copy link

codecov bot commented May 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
fuzz-compress 41.35% <ø> (ø)
fuzz-decompress 30.98% <ø> (-0.12%) ⬇️
test-aarch64-apple-darwin 93.37% <ø> (-0.01%) ⬇️
test-x86_64-apple-darwin 91.70% <ø> (ø)
test-x86_64-unknown-linux-gnu 90.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libz-rs-sys-cdylib/src/gz.rs 91.21% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@folkertdev folkertdev force-pushed the gzprintf branch 4 times, most recently from 93af675 to 05efb52 Compare May 31, 2025 17:31
@folkertdev folkertdev changed the base branch from main to run-c-tests May 31, 2025 17:31
@folkertdev folkertdev force-pushed the gzprintf branch 2 times, most recently from 97cebe8 to 952a9dd Compare May 31, 2025 17:38
folkertdev
folkertdev commented May 31, 2025
View reviewed changes
Copy link
Member Author

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @brian-pane, does this implementation look right to you?

brian-pane
brian-pane reviewed Jun 1, 2025
View reviewed changes
brian-pane
brian-pane reviewed Jun 1, 2025
View reviewed changes
Base automatically changed from run-c-tests to main June 2, 2025 14:30
@folkertdev folkertdev force-pushed the gzprintf branch 3 times, most recently from fd4cb3c to e63694c Compare June 2, 2025 19:05
@folkertdev folkertdev requested a review from bjorn3 June 2, 2025 19:10
bjorn3
bjorn3 requested changes Jun 3, 2025
View reviewed changes
@folkertdev folkertdev force-pushed the gzprintf branch 2 times, most recently from b2be68f to f78b30d Compare June 3, 2025 19:21
@folkertdev folkertdev requested a review from bjorn3 June 3, 2025 19:43
bjorn3
bjorn3 reviewed Jun 4, 2025
View reviewed changes
@folkertdev folkertdev merged commit 9da10ca into main Jun 4, 2025
24 checks passed
@folkertdev folkertdev deleted the gzprintf branch June 4, 2025 10:20
@BrewTestBot BrewTestBot mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

+1 more reviewer

@brian-pane brian-pane brian-pane left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@folkertdev @bjorn3 @brian-pane