Skip to content

Conversation

@brian-pane
Copy link

No description provided.

@codecov
Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
libz-rs-sys/src/gz.rs 82.50% 7 Missing ⚠️
Flag Coverage Δ
fuzz-compress ?
fuzz-decompress ?
test-aarch64-apple-darwin 89.11% <77.50%> (+1.64%) ⬆️
test-x86_64-apple-darwin 85.64% <77.50%> (-0.11%) ⬇️
test-x86_64-unknown-linux-gnu 87.06% <72.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libz-rs-sys/src/gz.rs 93.12% <82.50%> (+3.39%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines 1669 to 1671
// TODO safety comment
let input_slice = unsafe { slice::from_raw_parts_mut(state.input, n) };
input_slice.fill(0u8);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is almost certainly unsound. Would https://doc.rust-lang.org/std/primitive.pointer.html#method.write_bytes work?

@folkertdev folkertdev merged commit 56b56b4 into trifectatechfoundation:main May 4, 2025
24 checks passed
@brian-pane brian-pane deleted the gzseek branch May 27, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants