Make gzclose_r and gzclose_w part of the public API

[brian-pane]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
libz-rs-sys/src/gz.rs	83.33%	4 Missing ⚠️

Flag	Coverage Δ
fuzz-compress	?
fuzz-decompress	?
test-aarch64-apple-darwin	88.60% <4.16%> (-0.67%)	⬇️
test-x86_64-apple-darwin	87.13% <4.16%> (-0.11%)	⬇️
test-x86_64-unknown-linux-gnu	90.45% <79.16%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
libz-rs-sys/src/gz.rs	91.19% <83.33%> (+0.06%)	⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[folkertdev]

These symbols are not exported by libz.so, so why would we make them part of the public API?

[brian-pane]

They are part of the public API in zlib-ng, https://github.com/zlib-ng/zlib-ng/blob/2.2.4/zlib.h.in#L1624-L1625

[folkertdev]

Some nits/questions.

In general, are there any tests that can be moved from libz-rs-sys to test-libz-rs-sys now that these functions are public?

[brian-pane]

I just checked the existing tests, and they all exercise these functions indirectly via the gzclose that was already public, so there aren't any test cases that can move from libz-rs-sys to test-libz-rs-sys.