Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty favicon.ico to fix CI #623

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add empty favicon.ico to fix CI #623

merged 1 commit into from
Oct 8, 2024

Conversation

tricknotes
Copy link
Owner

This is the same PR as the following.

To avoid `ActionController::RoutingError` from headless chrome for Rails < 7.2.
Like the following:
```
Failures:

  1) User views ember app using route helper
     Failure/Error: raise ActionController::RoutingError, "No route matches [#{env['REQUEST_METHOD']}] #{env['PATH_INFO'].inspect}"

     ActionController::RoutingError:
       No route matches [GET] "/favicon.ico"
```
@tricknotes tricknotes merged commit 6508be5 into main Oct 8, 2024
27 checks passed
@tricknotes tricknotes deleted the fix-ci branch October 8, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant