fix bug where the before_commit hook runs before the after_begin hook #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey can happen out of order
|
PR that introduced issue here: https://github.com/trialspark/sqlalchemy-continuum/pull/14/files |
|
Figuring out how to run tests against this repo now |
wjordan213
force-pushed
the
wjordan213__PLATFORM-943__merge_after_begin_and_before_commit_hooks
branch
from
42562b8
to
308f203
Compare
rmurcek
approved these changes
Jul 28, 2021
minznerjosh
reviewed
Jul 28, 2021
|
yeah were the tests running properly before? I'm unable to run any tests against even master using: |
|
getting random schema errors and things |
|
@minznerjosh if I ran this against the spark repo's codebase would that be sufficient? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the before commit and after begin hooks due to the fact that they can happen out of order.
This addresses an issue that I was having when testing the DMR project locally. I observed rows being added to the audit transactions table that did not contain a value for origin_app. Implementing this change in the library code running inside of the docker container executing the data migration fixed the issue that I was having.