-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support USE_{SOME COIN}
compilation flags
#2375
Comments
USE_*
compilation flags are brokenUSE_{SOME COIN}
compilation flags
The What do you think @matejcik? |
Actually we should ideally be distinguishing between Zcash shielded and unshielded, because the memory overhead of shielded transactions appears to be overwhelming. So |
I don't see the need for per-coin use flags, there is no plan to mix-and-match. We can flip "bitcoin-only" to something like "USE_ALL_FEATURES", or optionally "USE_ALTCOINS" and "USE_WEBAUTHN", and then add "USE_ZCASH_SHIELDED" (which also implies inclusion of Zcash unshielded) |
True, what I am proposing is very fine-grained. However, considering that we are running out of flash memory, we will have to resort to creating specialized firmwares, such as the one for Zcash-shielded transactions. I imagine this would then be helpful in creating thematic firmwares, such as "privacy firmware" with BTC + Zcash (shielded) + Monero or something similar. |
I am not yet convinced that "specialized firmwares" are a sensible way forward here. Some sort of pluggable architecture ala Ledger is an equally convincing alternative. that said, I generally agree with you but I wouldn't go ahead with the fine-grained control until we actually start using it. |
A pluggable architecture would be a nice solution, but we are very far from being able to implement that, whereas specialized firmwares is something that we are already doing. Anyway, I can understand the hesitation around prematurely implementing fine-grained control, so let's deal with this as we go and focus effort on #2370. |
definitely +1 to being able to switch in and out features as required (even as an interim measure), the flash size constraint has been a real challenge for #2372, particularly because we do need to be able to test -each- coin (and will going forward also need to include our own) (the version of this i started in case it is of use to y'all: per-coin-flags.txt, though there are still a lot of places to propagate these changes) |
Compilation flags of type
USE_*
are not separable, i.e. they can be all disabled (byBITCOIN_ONLY=1
), or all enabled (otherwise), but they cannot be set individually.For example for
USE_ETHEREUM=0
I get this errorCompilation flags will play a critical role in getting new coins and features into overflowing flash memory.
To be specific I need to disable some coins to push Zcash shielded transaction into flash.
The text was updated successfully, but these errors were encountered: