Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce fee thresholds for altcoins that are not Bitcoin-like (ETH, XRP, NEM etc.) #1191

Open
tsusanka opened this issue Aug 17, 2020 · 2 comments
Open

Introduce fee thresholds for altcoins that are not Bitcoin-like (ETH, XRP, NEM etc.) #1191

tsusanka opened this issue Aug 17, 2020 · 2 comments
Assignees
@mmilata
Labels
altcoin Any non-Bitcoin coins core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Aug 17, 2020 •
edited
Loading

Follow up of #1087 where we have realized we do not have fee threshold checks for altcoins that are not Bitcoin-based (NEM, XRP, ETH etc.). Let's add both soft and hard limit for all supported coins. Product suggests 10x for an average fee cost for the soft limit and 100x for the hard limit. Let's discuss this in Triage though.
@tsusanka tsusanka added core Trezor Core firmware. Runs on Trezor Model T and T2B1. altcoin Any non-Bitcoin coins labels Aug 17, 2020
@tsusanka tsusanka added this to the backlog milestone Aug 17, 2020
@tsusanka tsusanka mentioned this issue Aug 17, 2020
Closed
@mmilata mmilata self-assigned this Aug 21, 2020
@prusnak
Copy link
Member

prusnak commented Aug 28, 2020

This has been fixed via f51fac3 right?

@tsusanka
Copy link
Contributor Author

No. In here I meant altcoins that are not Bitcoin-based (ETH, NEM, XRP etc.). Let me rephrase the issue.

@tsusanka tsusanka changed the title Introduce fee thresholds for altcoins Introduce fee thresholds for altcoins that are not Bitcoin-like (ETH, XRP, NEM etc.) Aug 28, 2020
@tsusanka tsusanka removed the S3 Major label Feb 19, 2021
@tsusanka tsusanka removed this from the backlog milestone Oct 6, 2021
@hynek-jina hynek-jina added LOW and removed MEDIUM labels Dec 2, 2021
@hynek-jina hynek-jina added the feature Product related issue visible for end user label Dec 17, 2021
@hynek-jina hynek-jina removed the LOW label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmilata mmilata

Labels
altcoin Any non-Bitcoin coins core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user
Projects
Firmware
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@prusnak @mmilata @tsusanka @hynek-jina