Skip to content

Commit d3cd0e0

Browse files
chetoncheton
committed
Use React.PureComponent instead of shallowCompare
1 parent 2ad1631 commit d3cd0e0

File tree

7 files changed

+12
-26
lines changed

7 files changed

+12
-26
lines changed

‎dist/react-buttons.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/react-buttons.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/bundle.js‎

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25460,10 +25460,6 @@ var _react = __webpack_require__("../node_modules/react/react.js");
2546025460

2546125461
var _react2 = _interopRequireDefault(_react);
2546225462

25463-
var _reactAddonsShallowCompare = __webpack_require__("../node_modules/react-addons-shallow-compare/index.js");
25464-
25465-
var _reactAddonsShallowCompare2 = _interopRequireDefault(_reactAddonsShallowCompare);
25466-
2546725463
var _index = __webpack_require__("../src/index.styl");
2546825464

2546925465
var _index2 = _interopRequireDefault(_index);
@@ -25480,8 +25476,8 @@ function _possibleConstructorReturn(self, call) { if (!self) { throw new Referen
2548025476

2548125477
function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }
2548225478

25483-
var Button = (_temp = _class = function (_Component) {
25484-
_inherits(Button, _Component);
25479+
var Button = (_temp = _class = function (_PureComponent) {
25480+
_inherits(Button, _PureComponent);
2548525481

2548625482
function Button() {
2548725483
_classCallCheck(this, Button);
@@ -25490,11 +25486,6 @@ var Button = (_temp = _class = function (_Component) {
2549025486
}
2549125487

2549225488
_createClass(Button, [{
25493-
key: 'shouldComponentUpdate',
25494-
value: function shouldComponentUpdate(nextProps, nextState) {
25495-
return (0, _reactAddonsShallowCompare2.default)(this, nextProps, nextState);
25496-
}
25497-
}, {
2549825489
key: 'render',
2549925490
value: function render() {
2550025491
var _classes;
@@ -25525,7 +25516,7 @@ var Button = (_temp = _class = function (_Component) {
2552525516
}]);
2552625517

2552725518
return Button;
25528-
}(_react.Component), _class.propTypes = {
25519+
}(_react.PureComponent), _class.propTypes = {
2552925520
componentClass: _propTypes2.default.oneOfType([_propTypes2.default.func, _propTypes2.default.string]),
2553025521
type: _propTypes2.default.oneOf(['button', 'reset', 'submit']),
2553125522
btnSize: _propTypes2.default.oneOf(['lg', 'md', 'sm', 'xs', 'large', 'medium', 'small', 'extra-small']),
@@ -26870,4 +26861,4 @@ _reactDom2.default.render(_react2.default.createElement(App, null), document.get
2687026861
/***/ })
2687126862

2687226863
/******/ });
26873-
//# sourceMappingURL=bundle.js.map?47cf46dc5bfd4af2c21d
26864+
//# sourceMappingURL=bundle.js.map?00f4324d0b23b960da84

‎docs/bundle.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@
1111
</head>
1212
<body>
1313
<div id="container"></div>
14-
<script type="text/javascript" src="bundle.js?47cf46dc5bfd4af2c21d"></script></body>
14+
<script type="text/javascript" src="bundle.js?00f4324d0b23b960da84"></script></body>
1515
</html>

‎package.json‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@trendmicro/react-buttons",
3-
"version": "1.0.3",
3+
"version": "1.0.4",
44
"description": "Trend Micro Components: React Buttons",
55
"main": "lib/index.js",
66
"files": [
@@ -55,8 +55,7 @@
5555
},
5656
"dependencies": {
5757
"classnames": "^2.2.5",
58-
"prop-types": "^15.5.8",
59-
"react-addons-shallow-compare": "^0.14.0 || ^15.0.0"
58+
"prop-types": "^15.5.8"
6059
},
6160
"devDependencies": {
6261
"@trendmicro/react-loader": "~0.5.2",

‎src/Button.jsx‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import classNames from 'classnames';
22
import PropTypes from 'prop-types';
3-
import React, { Component } from 'react';
4-
import shallowCompare from 'react-addons-shallow-compare';
3+
import React, { PureComponent } from 'react';
54
import styles from './index.styl';
65

7-
class Button extends Component {
6+
class Button extends PureComponent {
87
static propTypes = {
98
componentClass: PropTypes.oneOfType([
109
PropTypes.func,
@@ -60,9 +59,6 @@ class Button extends Component {
6059
dropdownToggle: false
6160
};
6261

63-
shouldComponentUpdate(nextProps, nextState) {
64-
return shallowCompare(this, nextProps, nextState);
65-
}
6662
render() {
6763
const {
6864
className,

0 commit comments

Comments
 (0)