Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-agent extractor/function #1483

Open
darach opened this issue Feb 24, 2022 · 10 comments
Open

User-agent extractor/function #1483

darach opened this issue Feb 24, 2022 · 10 comments
Labels
_complexity:low A task with a low complexity that should be easy to understand documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberfest productivity _size:small A small task that should be quick to do

Comments

@darach
Copy link
Member

darach commented Feb 24, 2022

Describe the problem you are trying to solve

As a user, I would like an extractor/function to dissect HTTP user agent headers

Describe the solution you'd like

Something along the lines of logstash's user-agent plugin: https://www.elastic.co/guide/en/logstash/current/plugins-filters-useragent.html

@darach darach added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers productivity _complexity:low A task with a low complexity that should be easy to understand _size:small A small task that should be quick to do labels Feb 24, 2022
@darach darach changed the title Use-agent extractor User-agent extractor Feb 24, 2022
@Licenser
Copy link
Member

Should this perhaps rather be a tremor function instead of a extractor? We do support all the needed logic already and can avoid adding one-of-a-kind extractors this way.

@darach darach changed the title User-agent extractor User-agent extractor/function Feb 24, 2022
@darach
Copy link
Member Author

darach commented Feb 24, 2022

Yep - a function would be fine too - updating issue

@darach
Copy link
Member Author

darach commented Feb 24, 2022

There are many standard headers that we could have util functions for - like repeated headers, content-type/mime, accept ...

@Licenser
Copy link
Member

I love that idea, a http module with the common logic would be absolutely great!

@mfelsche
Copy link
Member

And it would make for great first issues too :D

@darach
Copy link
Member Author

darach commented Feb 24, 2022

Each connector should probably have its own module of utilities - it worked well for otel ...

@tobehardest
Copy link

Does this problem still need to be solved? I'd like to try it out if I can.

@Licenser
Copy link
Member

Heya,

yes it does and it should be a good issue to start with, I'll assign it to you, feel free to hop by https://chat.tremor.rs if you need any help or pointers :)

@Licenser
Copy link
Member

Licenser commented Apr 4, 2023

heya @tobehardest do you need any help from us?

@Licenser
Copy link
Member

Licenser commented Apr 6, 2023

unassigning this again due to lack of response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_complexity:low A task with a low complexity that should be easy to understand documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberfest productivity _size:small A small task that should be quick to do
Projects
None yet
Development

No branches or pull requests

4 participants