Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Params in with clauses #1225

Open
yatinmaan opened this issue Sep 22, 2021 · 3 comments
Open

Duplicate Params in with clauses #1225

yatinmaan opened this issue Sep 22, 2021 · 3 comments
Labels
bug Something isn't working _complexity:low A task with a low complexity that should be easy to understand good first issue Good for newcomers hacktoberfest

Comments

@yatinmaan
Copy link
Contributor

Problem

It is possible to provide duplicate params in a with clause. The last one overwrites any previous values.

Steps

define qos::wal operator wal
    with
      read_count = 10,
      max_elements = 1000,
      max_bytes = 10485760
      read_count = 20, # <--- This `20` overwrites the previous `10`.
    end;

Possible Solution(s)

Throw an error instead of silently using the last value.

@yatinmaan yatinmaan added the bug Something isn't working label Sep 22, 2021
@Licenser
Copy link
Member

good catch!

@mfelsche mfelsche added _complexity:low A task with a low complexity that should be easy to understand good first issue Good for newcomers hacktoberfest labels Sep 30, 2021
@samgans
Copy link

samgans commented Oct 14, 2021

Hi! If this is still not fixed, you can assign the issue to me and I will take a look on it.

@Licenser
Copy link
Member

I think @yatinmaan might have fixed this in the modular subquery branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working _complexity:low A task with a low complexity that should be easy to understand good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants