Skip to content

Commit 99d1b19

Browse files
authored
fix: conditionally add sign=False on dulwich>=0.24.3 (#458)
1 parent 8c91f26 commit 99d1b19

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/scmrepo/git/backend/dulwich/__init__.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,13 +369,18 @@ def _expand_paths(self, paths: list[str], force: bool = False) -> Iterator[str]:
369369
yield rel
370370

371371
def commit(self, msg: str, no_verify: bool = False):
372+
from dulwich import __version__ as dulwich_version
372373
from dulwich.errors import CommitError
373374
from dulwich.porcelain import Error, TimezoneFormatError, commit
374375
from dulwich.repo import InvalidUserIdentity
375376

377+
commit_kwargs: dict[str, Any] = {}
378+
if dulwich_version >= (0, 24, 3):
379+
commit_kwargs["sign"] = False
380+
376381
with reraise((Error, CommitError), SCMError("Git commit failed")):
377382
try:
378-
commit(self.repo, message=msg, no_verify=no_verify, sign=False)
383+
commit(self.repo, message=msg, no_verify=no_verify, **commit_kwargs)
379384
except InvalidUserIdentity as exc:
380385
raise SCMError("Git username and email must be configured") from exc
381386
except TimezoneFormatError as exc:

0 commit comments

Comments
 (0)