Skip to content

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Feb 26, 2024

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™


This PR fixes a bug in the collection of plots definitions. The bug exists when there is a plot collected from a nested dvc.yaml that uses separate files for the x and y values.

e.g.

- Error vs max_leaf_nodes:
    template: simple
    x: 
      dvclive/plots/metrics/Max_Leaf_Nodes.tsv: Max_Leaf_Nodes
    y:
      dvclive/plots/metrics/Error.tsv: Error

in {root}/pipelines/data-increment/dvc.yaml

Previously the path to the x file was not updated to take into account the path to the dvc.yaml that it exists in.

For more context see this thread.

@mattseddon mattseddon added bug Did we break something? A: plots Related to the plots labels Feb 26, 2024
@mattseddon mattseddon self-assigned this Feb 26, 2024
@codecov
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 90.69%. Comparing base (84a1750) to head (93403de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10318      +/-   ##
==========================================
+ Coverage   90.67%   90.69%   +0.02%     
==========================================
  Files         499      499              
  Lines       38459    38504      +45     
  Branches     5552     5555       +3     
==========================================
+ Hits        34871    34921      +50     
+ Misses       2949     2946       -3     
+ Partials      639      637       -2     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@mattseddon mattseddon requested a review from a team February 26, 2024 00:29
@mattseddon mattseddon marked this pull request as ready for review February 26, 2024 00:29
@mattseddon mattseddon enabled auto-merge (squash) February 26, 2024 19:32
@mattseddon mattseddon merged commit 9f66897 into treeverse:main Feb 26, 2024
@mattseddon mattseddon deleted the fix-nested-x-dict branch February 27, 2024 00:31
BradyJ27 pushed a commit to BradyJ27/dvc that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: plots Related to the plots bug Did we break something?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants