repo: add subrepo_relpath property for Studio live experiments monorepo support #10283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
add-subrepo-helper
branch
from
0f60e26 to
7c5c1c7
Compare
mattseddon
commented
Feb 6, 2024
dvc/repo/__init__.py
Outdated
|
|
||
| relpath = as_posix(self.fs.relpath(self.root_dir, scm_root_dir)) | ||
|
|
||
| return "" if relpath == "." else relpath |
Contributor
Author
There was a problem hiding this comment.
Part of https://github.com/iterative/studio/issues/8848 is that we need to send the relative subrepo path to Studio via dvc-studio-client. Both dvc and dvclive use the client to post live experiments metrics to Studio. To me, it makes sense to have this helper here as we have all of the necessary fixtures to test the behaviour.
mattseddon
force-pushed
the
add-subrepo-helper
branch
from
7c5c1c7 to
7ce28cd
Compare
efiop
approved these changes
Feb 6, 2024
mattseddon
force-pushed
the
add-subrepo-helper
branch
from
7ce28cd to
f581be2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10283 +/- ##
==========================================
+ Coverage 90.41% 90.43% +0.02%
==========================================
Files 494 494
Lines 37775 37811 +36
Branches 5467 5468 +1
==========================================
+ Hits 34153 34194 +41
+ Misses 2987 2984 -3
+ Partials 635 633 -2 ☔ View full report in Codecov by Sentry. |
mattseddon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to https://github.com/iterative/studio/issues/8848